erhan/abap-llm
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix coverage with several contract classes; table annotation and file path checks; clean task dir on write

Browse Source 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014aUaQeLnwbb1zTpN7kHeat
This commit is contained in:
Kral
2026-10-03 08:44:35 +02:00
parent fb576b0954
commit 03ab36149e
388 changed files with 28620 additions and 339 deletions
Download Patch File Download Diff File Expand all files Collapse all files

137
tasks_gen/eval/G0113/reference/sample_batcher.clas.abap Normal file
View File

@@ -0,0 +1,137 @@
CLASS {{p}}sample_batcher DEFINITION PUBLIC FINAL CREATE PUBLIC.
PUBLIC SECTION.
TYPES:
ty_test_type TYPE c LENGTH 4,
ty_sample_id TYPE c LENGTH 10,
ty_priority TYPE i.
TYPES:
BEGIN OF ty_batch,
test_type TYPE ty_test_type,
total TYPE i,
urgent TYPE i,
END OF ty_batch.
TYPES tt_batches TYPE STANDARD TABLE OF ty_batch WITH EMPTY KEY.
METHODS add_sample
IMPORTING iv_sample_id TYPE ty_sample_id
iv_test_type TYPE ty_test_type
iv_priority TYPE ty_priority
RETURNING VALUE(rv_added) TYPE abap_bool.
METHODS get_batches
RETURNING VALUE(rt_batches) TYPE tt_batches.
METHODS get_batch
IMPORTING iv_test_type TYPE ty_test_type
RETURNING VALUE(rs_batch) TYPE ty_batch.
PRIVATE SECTION.
CONSTANTS:
BEGIN OF c_priority,
urgent TYPE ty_priority VALUE 1,
normal TYPE ty_priority VALUE 2,
routine TYPE ty_priority VALUE 3,
END OF c_priority.
TYPES:
BEGIN OF ty_sample_entry,
sample_id TYPE ty_sample_id,
END OF ty_sample_entry.
TYPES:
tt_batch_index TYPE SORTED TABLE OF ty_batch WITH UNIQUE KEY test_type,
tt_sample_index TYPE HASHED TABLE OF ty_sample_entry WITH UNIQUE KEY sample_id.
DATA mt_batches TYPE tt_batch_index.
DATA mt_samples TYPE tt_sample_index.
METHODS normalize_id
IMPORTING iv_id TYPE ty_sample_id
RETURNING VALUE(rv_id) TYPE ty_sample_id.
METHODS normalize_type
IMPORTING iv_type TYPE ty_test_type
RETURNING VALUE(rv_type) TYPE ty_test_type.
METHODS is_valid_priority
IMPORTING iv_priority TYPE ty_priority
RETURNING VALUE(rv_valid) TYPE abap_bool.
METHODS count_sample
IMPORTING iv_test_type TYPE ty_test_type
iv_priority TYPE ty_priority.
ENDCLASS.
CLASS {{p}}sample_batcher IMPLEMENTATION.
METHOD add_sample.
DATA(lv_sample_id) = normalize_id( iv_sample_id ).
DATA(lv_test_type) = normalize_type( iv_test_type ).
IF lv_sample_id IS INITIAL
OR lv_test_type IS INITIAL
OR is_valid_priority( iv_priority ) = abap_false
OR line_exists( mt_samples[ sample_id = lv_sample_id ] ).
RETURN.
ENDIF.
INSERT VALUE #( sample_id = lv_sample_id ) INTO TABLE mt_samples.
count_sample( iv_test_type = lv_test_type
iv_priority = iv_priority ).
rv_added = abap_true.
ENDMETHOD.
METHOD get_batches.
rt_batches = mt_batches.
SORT rt_batches BY test_type.
ENDMETHOD.
METHOD get_batch.
DATA(lv_test_type) = normalize_type( iv_test_type ).
READ TABLE mt_batches INTO rs_batch WITH TABLE KEY test_type = lv_test_type.
IF sy-subrc <> 0.
rs_batch = VALUE #( test_type = lv_test_type ).
ENDIF.
ENDMETHOD.
METHOD normalize_id.
rv_id = to_upper( replace( val = iv_id sub = ` ` with = `` occ = 0 ) ).
ENDMETHOD.
METHOD normalize_type.
rv_type = to_upper( replace( val = iv_type sub = ` ` with = `` occ = 0 ) ).
ENDMETHOD.
METHOD is_valid_priority.
rv_valid = xsdbool( iv_priority = c_priority-urgent
OR iv_priority = c_priority-normal
OR iv_priority = c_priority-routine ).
ENDMETHOD.
METHOD count_sample.
READ TABLE mt_batches ASSIGNING FIELD-SYMBOL(<ls_batch>)
WITH TABLE KEY test_type = iv_test_type.
IF sy-subrc <> 0.
INSERT VALUE #( test_type = iv_test_type ) INTO TABLE mt_batches
ASSIGNING <ls_batch>.
ENDIF.
<ls_batch>-total = <ls_batch>-total + 1.
IF iv_priority = c_priority-urgent.
<ls_batch>-urgent = <ls_batch>-urgent + 1.
ENDIF.
ENDMETHOD.
ENDCLASS.

88
tasks_gen/eval/G0113/reference/sample_batcher.testclasses.abap Normal file
View File

@@ -0,0 +1,88 @@
CLASS ltc_sample_batcher DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
PRIVATE SECTION.
DATA mo_cut TYPE REF TO {{p}}sample_batcher.
METHODS setup.
METHODS counts_samples FOR TESTING.
METHODS counts_urgent FOR TESTING.
METHODS rejects_empty_id FOR TESTING.
METHODS rejects_duplicate FOR TESTING.
METHODS rejects_bad_priority FOR TESTING.
METHODS normalizes_input FOR TESTING.
METHODS batches_sorted FOR TESTING.
METHODS unknown_type_is_zero FOR TESTING.
ENDCLASS.
CLASS ltc_sample_batcher IMPLEMENTATION.
METHOD setup.
mo_cut = NEW {{p}}sample_batcher( ).
ENDMETHOD.
METHOD counts_samples.
mo_cut->add_sample( iv_sample_id = 'S1' iv_test_type = 'GLU' iv_priority = 2 ).
mo_cut->add_sample( iv_sample_id = 'S2' iv_test_type = 'GLU' iv_priority = 3 ).
DATA(ls_batch) = mo_cut->get_batch( 'GLU' ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = ls_batch-total ).
ENDMETHOD.
METHOD counts_urgent.
mo_cut->add_sample( iv_sample_id = 'S1' iv_test_type = 'K' iv_priority = 1 ).
mo_cut->add_sample( iv_sample_id = 'S2' iv_test_type = 'K' iv_priority = 2 ).
DATA(ls_batch) = mo_cut->get_batch( 'K' ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = ls_batch-total ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = ls_batch-urgent ).
ENDMETHOD.
METHOD rejects_empty_id.
cl_abap_unit_assert=>assert_equals(
exp = abap_false
act = mo_cut->add_sample( iv_sample_id = ''
iv_test_type = 'GLU'
iv_priority = 2 ) ).
ENDMETHOD.
METHOD rejects_duplicate.
mo_cut->add_sample( iv_sample_id = 'S1' iv_test_type = 'GLU' iv_priority = 2 ).
cl_abap_unit_assert=>assert_equals(
exp = abap_false
act = mo_cut->add_sample( iv_sample_id = 'S1'
iv_test_type = 'NA'
iv_priority = 2 ) ).
ENDMETHOD.
METHOD rejects_bad_priority.
cl_abap_unit_assert=>assert_equals(
exp = abap_false
act = mo_cut->add_sample( iv_sample_id = 'S1'
iv_test_type = 'GLU'
iv_priority = 9 ) ).
ENDMETHOD.
METHOD normalizes_input.
cl_abap_unit_assert=>assert_equals(
exp = abap_true
act = mo_cut->add_sample( iv_sample_id = 's1'
iv_test_type = 'glu'
iv_priority = 2 ) ).
DATA(lt_batches) = mo_cut->get_batches( ).
cl_abap_unit_assert=>assert_equals( exp = 'GLU' act = lt_batches[ 1 ]-test_type ).
ENDMETHOD.
METHOD batches_sorted.
mo_cut->add_sample( iv_sample_id = 'S1' iv_test_type = 'NA' iv_priority = 2 ).
mo_cut->add_sample( iv_sample_id = 'S2' iv_test_type = 'GLU' iv_priority = 2 ).
DATA(lt_batches) = mo_cut->get_batches( ).
cl_abap_unit_assert=>assert_equals( exp = 'GLU' act = lt_batches[ 1 ]-test_type ).
cl_abap_unit_assert=>assert_equals( exp = 'NA' act = lt_batches[ 2 ]-test_type ).
ENDMETHOD.
METHOD unknown_type_is_zero.
DATA(ls_batch) = mo_cut->get_batch( 'XXX' ).
cl_abap_unit_assert=>assert_equals( exp = 0 act = ls_batch-total ).
cl_abap_unit_assert=>assert_equals( exp = 0 act = ls_batch-urgent ).
ENDMETHOD.
ENDCLASS.