Fix coverage with several contract classes; table annotation and file path checks; clean task dir on write

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014aUaQeLnwbb1zTpN7kHeat
This commit is contained in:
Kral
2026-10-03 08:44:35 +02:00
parent fb576b0954
commit 03ab36149e
388 changed files with 28620 additions and 339 deletions

View File

@@ -0,0 +1,170 @@
REPORT {{p}}milk_sum.
DATA gv_region TYPE {{p}}farm-region.
PARAMETERS p_from TYPE d OBLIGATORY.
PARAMETERS p_to TYPE d OBLIGATORY.
SELECT-OPTIONS s_reg FOR gv_region.
CLASS lcl_report DEFINITION FINAL.
PUBLIC SECTION.
TYPES:
BEGIN OF ty_line,
farm_id TYPE {{p}}farm-farm_id,
farm_name TYPE {{p}}farm-farm_name,
region TYPE {{p}}farm-region,
litres TYPE {{p}}milk-litres,
deliveries TYPE i,
END OF ty_line,
tt_line TYPE STANDARD TABLE OF ty_line WITH EMPTY KEY,
tt_region TYPE RANGE OF {{p}}farm-region.
METHODS select_data
IMPORTING iv_from TYPE d
iv_to TYPE d
it_region TYPE tt_region
RETURNING VALUE(rt_lines) TYPE tt_line.
METHODS display
CHANGING ct_lines TYPE tt_line.
PRIVATE SECTION.
TYPES:
BEGIN OF ty_sum,
farm_id TYPE {{p}}milk-farm_id,
litres TYPE {{p}}milk-litres,
deliveries TYPE i,
END OF ty_sum,
tt_sum TYPE HASHED TABLE OF ty_sum WITH UNIQUE KEY farm_id.
METHODS sum_deliveries
IMPORTING iv_from TYPE d
iv_to TYPE d
RETURNING VALUE(rt_sum) TYPE tt_sum.
ENDCLASS.
CLASS lcl_report IMPLEMENTATION.
METHOD select_data.
SELECT farm_id, farm_name, region
FROM {{p}}farm
WHERE region IN @it_region
INTO TABLE @DATA(lt_farm).
DATA(lt_sum) = sum_deliveries( iv_from = iv_from iv_to = iv_to ).
LOOP AT lt_farm INTO DATA(ls_farm).
DATA(ls_line) = VALUE ty_line( farm_id = ls_farm-farm_id
farm_name = ls_farm-farm_name
region = ls_farm-region ).
READ TABLE lt_sum ASSIGNING FIELD-SYMBOL(<ls_sum>)
WITH TABLE KEY farm_id = ls_farm-farm_id.
IF sy-subrc = 0.
ls_line-litres = <ls_sum>-litres.
ls_line-deliveries = <ls_sum>-deliveries.
ENDIF.
APPEND ls_line TO rt_lines.
ENDLOOP.
SORT rt_lines BY litres DESCENDING farm_id ASCENDING.
ENDMETHOD.
METHOD sum_deliveries.
SELECT farm_id, litres
FROM {{p}}milk
WHERE deliv_date BETWEEN @iv_from AND @iv_to
INTO TABLE @DATA(lt_milk).
LOOP AT lt_milk INTO DATA(ls_milk).
READ TABLE rt_sum ASSIGNING FIELD-SYMBOL(<ls_sum>)
WITH TABLE KEY farm_id = ls_milk-farm_id.
IF sy-subrc <> 0.
DATA(ls_new) = VALUE ty_sum( farm_id = ls_milk-farm_id ).
INSERT ls_new INTO TABLE rt_sum ASSIGNING <ls_sum>.
ENDIF.
<ls_sum>-litres += ls_milk-litres.
<ls_sum>-deliveries += 1.
ENDLOOP.
ENDMETHOD.
METHOD display.
TRY.
cl_salv_table=>factory( IMPORTING r_salv_table = DATA(lo_alv)
CHANGING t_table = ct_lines ).
lo_alv->display( ).
CATCH cx_salv_msg INTO DATA(lx_error).
MESSAGE lx_error TYPE 'I' DISPLAY LIKE 'E'.
ENDTRY.
ENDMETHOD.
ENDCLASS.
START-OF-SELECTION.
DATA(go_report) = NEW lcl_report( ).
DATA(gt_lines) = go_report->select_data( iv_from = p_from iv_to = p_to it_region = s_reg[] ).
go_report->display( CHANGING ct_lines = gt_lines ).
CLASS ltc_report DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
PRIVATE SECTION.
CLASS-DATA go_env TYPE REF TO if_osql_test_environment.
CLASS-METHODS class_setup.
CLASS-METHODS class_teardown.
METHODS sums_and_counts FOR TESTING.
METHODS missing_delivery FOR TESTING.
METHODS date_range FOR TESTING.
METHODS tie_break FOR TESTING.
ENDCLASS.
CLASS ltc_report IMPLEMENTATION.
METHOD class_setup.
go_env = cl_osql_test_environment=>create(
i_dependency_list = VALUE #( ( '{{P}}FARM' ) ( '{{P}}MILK' ) ) ).
DATA lt_farm TYPE STANDARD TABLE OF {{p}}farm WITH EMPTY KEY.
lt_farm = VALUE #( ( farm_id = '1' farm_name = 'A' region = 'X' )
( farm_id = '2' farm_name = 'B' region = 'X' )
( farm_id = '3' farm_name = 'C' region = 'Y' )
( farm_id = '4' farm_name = 'D' region = 'Y' )
( farm_id = '5' farm_name = 'E' region = 'X' ) ).
go_env->insert_test_data( lt_farm ).
DATA lt_milk TYPE STANDARD TABLE OF {{p}}milk WITH EMPTY KEY.
lt_milk = VALUE #( ( deliv_id = 1 farm_id = '1' deliv_date = '20260110' litres = 10 )
( deliv_id = 2 farm_id = '1' deliv_date = '20260120' litres = 5 )
( deliv_id = 3 farm_id = '2' deliv_date = '20260115' litres = 40 )
( deliv_id = 4 farm_id = '3' deliv_date = '20260116' litres = 20 )
( deliv_id = 5 farm_id = '5' deliv_date = '20260111' litres = 15 ) ).
go_env->insert_test_data( lt_milk ).
ENDMETHOD.
METHOD class_teardown.
go_env->destroy( ).
ENDMETHOD.
METHOD sums_and_counts.
DATA(lt_lines) = NEW lcl_report( )->select_data(
iv_from = '20260101' iv_to = '20260131' it_region = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = 5 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = '2' act = lt_lines[ 1 ]-farm_id ).
cl_abap_unit_assert=>assert_equals( exp = CONV {{p}}milk-litres( 40 ) act = lt_lines[ 1 ]-litres ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lt_lines[ 1 ]-deliveries ).
ENDMETHOD.
METHOD missing_delivery.
DATA(lt_lines) = NEW lcl_report( )->select_data(
iv_from = '20260101' iv_to = '20260131' it_region = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = '4' act = lt_lines[ 5 ]-farm_id ).
cl_abap_unit_assert=>assert_equals( exp = 0 act = lt_lines[ 5 ]-deliveries ).
cl_abap_unit_assert=>assert_equals( exp = 0 act = lt_lines[ 5 ]-litres ).
ENDMETHOD.
METHOD date_range.
DATA(lt_lines) = NEW lcl_report( )->select_data(
iv_from = '20260115' iv_to = '20260131' it_region = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = 5 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = '2' act = lt_lines[ 1 ]-farm_id ).
cl_abap_unit_assert=>assert_equals( exp = CONV {{p}}milk-litres( 40 ) act = lt_lines[ 1 ]-litres ).
cl_abap_unit_assert=>assert_equals( exp = '1' act = lt_lines[ 3 ]-farm_id ).
cl_abap_unit_assert=>assert_equals( exp = CONV {{p}}milk-litres( 5 ) act = lt_lines[ 3 ]-litres ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lt_lines[ 3 ]-deliveries ).
ENDMETHOD.
METHOD tie_break.
DATA(lt_lines) = NEW lcl_report( )->select_data(
iv_from = '20260101' iv_to = '20260131' it_region = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = '1' act = lt_lines[ 3 ]-farm_id ).
cl_abap_unit_assert=>assert_equals( exp = '5' act = lt_lines[ 4 ]-farm_id ).
ENDMETHOD.
ENDCLASS.