Eval review v1: checklist, review helper, 24 tasks reviewed; G0002/G0022 tests fixed; I/E generator definitions

- docs/eval-inceleme.md checklist; harness/review.py - 19 accept, 1 fix pending (G0019), 4 flagged (I/E tasks solvable without legacy code) - generator: categories I and E fix/refactor the seed object in place Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014aUaQeLnwbb1zTpN7kHeat
2026-10-03 06:23:38 +02:00
parent a12fa4dff6
commit 3550f0b651
38 changed files with 607 additions and 40 deletions
--- a/tasks_gen/eval/G0002/faulty/m0_delivery_schedule.clas.abap
+++ b/tasks_gen/eval/G0002/faulty/m0_delivery_schedule.clas.abap
@@ -46,7 +46,7 @@ CLASS {{p}}delivery_schedule IMPLEMENTATION.

  METHOD is_working_day.
    rv_working = xsdbool( is_weekend( iv_date ) = abap_false
-                          AND is_holiday( iv_date = iv_date
+                          OR is_holiday( iv_date = iv_date
                                          it_holidays = it_holidays ) = abap_false ).
  ENDMETHOD.

@@ -65,7 +65,7 @@ CLASS {{p}}delivery_schedule IMPLEMENTATION.
    ENDIF.
    DATA(lv_remaining) = iv_days.
    DATA(lv_step) = COND i( WHEN iv_days > 0 THEN 1 ELSE -1 ).
-    WHILE lv_remaining = 0.
+    WHILE lv_remaining <> 0.
      rv_date = rv_date + lv_step.
      IF is_working_day( iv_date = rv_date
                         it_holidays = it_holidays ) = abap_true.
--- a/tasks_gen/eval/G0002/faulty/m2_delivery_schedule.clas.abap
+++ b/tasks_gen/eval/G0002/faulty/m2_delivery_schedule.clas.abap
@@ -0,0 +1,104 @@
+CLASS {{p}}delivery_schedule DEFINITION PUBLIC FINAL CREATE PUBLIC.
+
+  PUBLIC SECTION.
+
+    TYPES ty_holidays TYPE STANDARD TABLE OF d WITH EMPTY KEY.
+
+    METHODS is_working_day
+      IMPORTING iv_date           TYPE d
+                it_holidays       TYPE ty_holidays
+      RETURNING VALUE(rv_working) TYPE abap_bool.
+
+    METHODS next_working_day
+      IMPORTING iv_date        TYPE d
+                it_holidays    TYPE ty_holidays
+      RETURNING VALUE(rv_date) TYPE d.
+
+    METHODS add_working_days
+      IMPORTING iv_start       TYPE d
+                iv_days        TYPE i
+                it_holidays    TYPE ty_holidays
+      RETURNING VALUE(rv_date) TYPE d.
+
+    METHODS count_working_days
+      IMPORTING iv_from         TYPE d
+                iv_to           TYPE d
+                it_holidays     TYPE ty_holidays
+      RETURNING VALUE(rv_count) TYPE i.
+
+  PRIVATE SECTION.
+
+    CONSTANTS c_reference_monday TYPE d VALUE '19000101'.
+
+    METHODS is_weekend
+      IMPORTING iv_date           TYPE d
+      RETURNING VALUE(rv_weekend) TYPE abap_bool.
+
+    METHODS is_holiday
+      IMPORTING iv_date           TYPE d
+                it_holidays       TYPE ty_holidays
+      RETURNING VALUE(rv_holiday) TYPE abap_bool.
+
+ENDCLASS.
+
+
+CLASS {{p}}delivery_schedule IMPLEMENTATION.
+
+  METHOD is_working_day.
+    rv_working = xsdbool( is_weekend( iv_date ) = abap_false
+                          AND is_holiday( iv_date = iv_date
+                                          it_holidays = it_holidays ) = abap_false ).
+  ENDMETHOD.
+
+  METHOD next_working_day.
+    rv_date = iv_date.
+    WHILE is_working_day( iv_date = rv_date
+                          it_holidays = it_holidays ) = abap_false.
+      rv_date = rv_date + 1.
+    ENDWHILE.
+  ENDMETHOD.
+
+  METHOD add_working_days.
+    rv_date = iv_start.
+    IF iv_days <> 0.
+      RETURN.
+    ENDIF.
+    DATA(lv_remaining) = iv_days.
+    DATA(lv_step) = COND i( WHEN iv_days > 0 THEN 1 ELSE -1 ).
+    WHILE lv_remaining <> 0.
+      rv_date = rv_date + lv_step.
+      IF is_working_day( iv_date = rv_date
+                         it_holidays = it_holidays ) = abap_true.
+        lv_remaining = lv_remaining - lv_step.
+      ENDIF.
+    ENDWHILE.
+  ENDMETHOD.
+
+  METHOD count_working_days.
+    rv_count = 0.
+    DATA(lv_date) = iv_from.
+    WHILE lv_date <= iv_to.
+      IF is_working_day( iv_date = lv_date
+                         it_holidays = it_holidays ) = abap_true.
+        rv_count = rv_count + 1.
+      ENDIF.
+      lv_date = lv_date + 1.
+    ENDWHILE.
+  ENDMETHOD.
+
+  METHOD is_weekend.
+    DATA(lv_days) = iv_date - c_reference_monday.
+    rv_weekend = xsdbool( lv_days MOD 7 >= 5 ).
+  ENDMETHOD.
+
+  METHOD is_holiday.
+    rv_holiday = abap_false.
+    LOOP AT it_holidays INTO DATA(lv_holiday).
+      IF lv_holiday = iv_date.
+        rv_holiday = abap_true.
+        RETURN.
+      ENDIF.
+    ENDLOOP.
+  ENDMETHOD.
+
+ENDCLASS.
--- a/tasks_gen/eval/G0002/faulty/m3_delivery_schedule.clas.abap
+++ b/tasks_gen/eval/G0002/faulty/m3_delivery_schedule.clas.abap
@@ -88,7 +88,7 @@ CLASS {{p}}delivery_schedule IMPLEMENTATION.

  METHOD is_weekend.
    DATA(lv_days) = iv_date - c_reference_monday.
-    rv_weekend = xsdbool( lv_days MOD 7 >= 6 ).
+    rv_weekend = xsdbool( lv_days MOD 8 >= 5 ).
  ENDMETHOD.

  METHOD is_holiday.
--- a/tasks_gen/eval/G0002/faulty/m4_delivery_schedule.clas.abap
+++ b/tasks_gen/eval/G0002/faulty/m4_delivery_schedule.clas.abap
@@ -88,14 +88,14 @@ CLASS {{p}}delivery_schedule IMPLEMENTATION.

  METHOD is_weekend.
    DATA(lv_days) = iv_date - c_reference_monday.
-    rv_weekend = xsdbool( lv_days MOD 7 >= 5 ).
+    rv_weekend = xsdbool( lv_days MOD 7 < 5 ).
  ENDMETHOD.

  METHOD is_holiday.
    rv_holiday = abap_false.
    LOOP AT it_holidays INTO DATA(lv_holiday).
      IF lv_holiday = iv_date.
-        rv_holiday = abap_false.
+        rv_holiday = abap_true.
        RETURN.
      ENDIF.
    ENDLOOP.
--- a/tasks_gen/eval/G0002/generation.json
+++ b/tasks_gen/eval/G0002/generation.json
@@ -19,6 +19,18 @@
   "stage": "validate",
   "oracle": 100.0,
   "null": 0
+  },
+  {
+   "stage": "manual_fix",
+   "by": "Claude review 2026-10-03",
+   "change": "Review: added hidden test count_duplicate_holidays (rule 7).",
+   "oracle": 100.0,
+   "null": 0,
+   "mutation": {
+    "valid": 4,
+    "killed": 4,
+    "ok": true
+   }
  }
 ],
 "accepted": true
--- a/tasks_gen/eval/G0002/hidden/t02_hidden.clas.abap
+++ b/tasks_gen/eval/G0002/hidden/t02_hidden.clas.abap
@@ -29,6 +29,7 @@ CLASS {{p}}t02_hidden DEFINITION PUBLIC FINAL CREATE PUBLIC
    METHODS add_days_backward FOR TESTING.
    METHODS count_working_days_inclusive FOR TESTING.
    METHODS count_reversed_range_is_zero FOR TESTING.
+    METHODS count_duplicate_holidays FOR TESTING.
 ENDCLASS.


@@ -123,6 +124,18 @@ CLASS {{p}}t02_hidden IMPLEMENTATION.
      msg = 'One holiday' ).
  ENDMETHOD.

+  METHOD count_duplicate_holidays.
+    DATA(lt_holidays) = VALUE {{p}}delivery_schedule=>ty_holidays(
+      ( c_tue_09 ) ( c_tue_09 ) ( CONV d( '20240201' ) ) ).
+    cl_abap_unit_assert=>assert_equals(
+      exp = 4
+      act = mo_cut->count_working_days( iv_from = c_mon_08 iv_to = c_fri_12 it_holidays = lt_holidays )
+      msg = 'A duplicate holiday counts one time; a holiday outside the interval has no effect' ).
+    cl_abap_unit_assert=>assert_equals(
+      exp = abap_false
+      act = mo_cut->is_working_day( iv_date = c_tue_09 it_holidays = lt_holidays ) ).
+  ENDMETHOD.
+
  METHOD count_reversed_range_is_zero.
    cl_abap_unit_assert=>assert_equals(
      exp = 0
--- a/tasks_gen/eval/G0002/mutation.json
+++ b/tasks_gen/eval/G0002/mutation.json
@@ -3,9 +3,33 @@
 "mutants": [
  {
   "object": "{{P}}DELIVERY_SCHEDULE",
-   "mutant": "line 68: <> -> = (rel)",
+   "mutant": "line 49: AND -> OR (logic)",
   "status": "killed",
-   "hidden": "9/12",
+   "hidden": "4/13",
+   "failed_tests": [
+    "ADD_DAYS_BACKWARD",
+    "ADD_DAYS_FORWARD",
+    "ADD_FORWARD_SKIPS_HOLIDAY",
+    "COUNT_DUPLICATE_HOLIDAYS",
+    "COUNT_WORKING_DAYS_INCLUSIVE",
+    "HOLIDAY_IS_NOT_WORKING",
+    "NEXT_DAY_FROM_WEEKEND",
+    "NEXT_DAY_SKIPS_HOLIDAYS",
+    "WEEKEND_IS_NOT_WORKING"
+   ]
+  },
+  {
+   "object": "{{P}}DELIVERY_SCHEDULE",
+   "mutant": "line 50: abap_false -> abap_true (bool)",
+   "status": "invalid",
+   "hidden": "0/0",
+   "failed_tests": []
+  },
+  {
+   "object": "{{P}}DELIVERY_SCHEDULE",
+   "mutant": "line 63: = -> <> (eq)",
+   "status": "killed",
+   "hidden": "10/13",
   "failed_tests": [
    "ADD_DAYS_BACKWARD",
    "ADD_DAYS_FORWARD",
@@ -14,46 +38,40 @@
  },
  {
   "object": "{{P}}DELIVERY_SCHEDULE",
-   "mutant": "line 72: - -> + (arith)",
-   "status": "invalid",
-   "hidden": "0/0",
-   "failed_tests": []
-  },
-  {
-   "object": "{{P}}DELIVERY_SCHEDULE",
-   "mutant": "line 81: = -> <> (eq)",
-   "status": "invalid",
-   "hidden": "0/0",
-   "failed_tests": []
-  },
-  {
-   "object": "{{P}}DELIVERY_SCHEDULE",
-   "mutant": "line 91: 5 -> 6 (const)",
+   "mutant": "line 91: 7 -> 8 (const)",
   "status": "killed",
-   "hidden": "7/12",
+   "hidden": "6/13",
   "failed_tests": [
    "ADD_DAYS_BACKWARD",
    "ADD_DAYS_FORWARD",
    "ADD_FORWARD_SKIPS_HOLIDAY",
+    "COUNT_DUPLICATE_HOLIDAYS",
+    "COUNT_WORKING_DAYS_INCLUSIVE",
    "NEXT_DAY_FROM_WEEKEND",
    "WEEKEND_IS_NOT_WORKING"
   ]
  },
  {
   "object": "{{P}}DELIVERY_SCHEDULE",
-   "mutant": "line 98: abap_true -> abap_false (bool)",
+   "mutant": "line 91: >= -> < (rel)",
   "status": "killed",
-   "hidden": "8/12",
+   "hidden": "3/13",
   "failed_tests": [
+    "ADD_DAYS_BACKWARD",
+    "ADD_DAYS_FORWARD",
    "ADD_FORWARD_SKIPS_HOLIDAY",
+    "COUNT_DUPLICATE_HOLIDAYS",
    "COUNT_WORKING_DAYS_INCLUSIVE",
-    "HOLIDAY_IS_NOT_WORKING",
-    "NEXT_DAY_SKIPS_HOLIDAYS"
+    "NEXT_DAY_FROM_WEEKEND",
+    "NEXT_DAY_SAME_FOR_WORKDAY",
+    "NEXT_DAY_SKIPS_HOLIDAYS",
+    "WEEKEND_IS_NOT_WORKING",
+    "WORKING_DAY_IS_TRUE"
   ]
  }
 ],
- "valid": 3,
- "killed": 3,
+ "valid": 4,
+ "killed": 4,
 "kill_rate": 1.0,
 "ok": true
 }
--- a/tasks_gen/eval/G0002/review.json
+++ b/tasks_gen/eval/G0002/review.json
@@ -0,0 +1,7 @@
+{
+ "decision": "accept",
+ "note": "Fixed: added count_duplicate_holidays; oracle 100, null 0, mutation 4/4.",
+ "by": "Claude",
+ "date": "2026-10-03",
+ "failed_checks": {}
+}