Eval review v1: checklist, review helper, 24 tasks reviewed; G0002/G0022 tests fixed; I/E generator definitions

- docs/eval-inceleme.md checklist; harness/review.py
- 19 accept, 1 fix pending (G0019), 4 flagged (I/E tasks solvable without legacy code)
- generator: categories I and E fix/refactor the seed object in place

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014aUaQeLnwbb1zTpN7kHeat
This commit is contained in:
Kral
2026-10-03 06:23:38 +02:00
parent a12fa4dff6
commit 3550f0b651
38 changed files with 607 additions and 40 deletions

View File

@@ -29,6 +29,7 @@ CLASS {{p}}t02_hidden DEFINITION PUBLIC FINAL CREATE PUBLIC
METHODS add_days_backward FOR TESTING.
METHODS count_working_days_inclusive FOR TESTING.
METHODS count_reversed_range_is_zero FOR TESTING.
METHODS count_duplicate_holidays FOR TESTING.
ENDCLASS.
@@ -123,6 +124,18 @@ CLASS {{p}}t02_hidden IMPLEMENTATION.
msg = 'One holiday' ).
ENDMETHOD.
METHOD count_duplicate_holidays.
DATA(lt_holidays) = VALUE {{p}}delivery_schedule=>ty_holidays(
( c_tue_09 ) ( c_tue_09 ) ( CONV d( '20240201' ) ) ).
cl_abap_unit_assert=>assert_equals(
exp = 4
act = mo_cut->count_working_days( iv_from = c_mon_08 iv_to = c_fri_12 it_holidays = lt_holidays )
msg = 'A duplicate holiday counts one time; a holiday outside the interval has no effect' ).
cl_abap_unit_assert=>assert_equals(
exp = abap_false
act = mo_cut->is_working_day( iv_date = c_tue_09 it_holidays = lt_holidays ) ).
ENDMETHOD.
METHOD count_reversed_range_is_zero.
cl_abap_unit_assert=>assert_equals(
exp = 0