Step F first pass: 81/92 accepted; budget floor 60 calls; rejected slots moved for regeneration

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014aUaQeLnwbb1zTpN7kHeat
This commit is contained in:
Kral
2026-10-03 12:10:52 +02:00
parent d3250acfb8
commit 39769afce8
741 changed files with 40573 additions and 317 deletions

View File

@@ -0,0 +1,157 @@
REPORT {{p}}carwash_rpt.
DATA gv_prog TYPE {{p}}carwash-wash_prog.
PARAMETERS: p_from TYPE d OBLIGATORY,
p_to TYPE d OBLIGATORY.
SELECT-OPTIONS: s_prog FOR gv_prog.
CLASS lcl_report DEFINITION FINAL.
PUBLIC SECTION.
TYPES:
BEGIN OF ty_line,
wash_prog TYPE {{p}}carwash-wash_prog,
prog_text TYPE {{p}}washpgm-prog_text,
washes TYPE i,
revenue TYPE {{p}}carwash-price,
vip_washes TYPE i,
vip_revenue TYPE {{p}}carwash-price,
END OF ty_line,
tt_line TYPE STANDARD TABLE OF ty_line WITH EMPTY KEY,
tt_prog TYPE RANGE OF {{p}}carwash-wash_prog.
METHODS collect
IMPORTING iv_from TYPE d
iv_to TYPE d
it_prog TYPE tt_prog
RETURNING VALUE(rt_lines) TYPE tt_line.
METHODS display
CHANGING ct_lines TYPE tt_line.
PRIVATE SECTION.
TYPES:
BEGIN OF ty_raw,
wash_prog TYPE {{p}}carwash-wash_prog,
prog_text TYPE {{p}}washpgm-prog_text,
price TYPE {{p}}carwash-price,
cust_type TYPE {{p}}carwash-cust_type,
END OF ty_raw,
tt_raw TYPE STANDARD TABLE OF ty_raw WITH EMPTY KEY.
METHODS read_washes
IMPORTING iv_from TYPE d
iv_to TYPE d
it_prog TYPE tt_prog
RETURNING VALUE(rt_raw) TYPE tt_raw.
METHODS aggregate
IMPORTING it_raw TYPE tt_raw
RETURNING VALUE(rt_lines) TYPE tt_line.
ENDCLASS.
CLASS lcl_report IMPLEMENTATION.
METHOD collect.
rt_lines = aggregate( read_washes( iv_from = iv_from
iv_to = iv_to
it_prog = it_prog ) ).
SORT rt_lines BY revenue DESCENDING.
ENDMETHOD.
METHOD read_washes.
SELECT c~wash_prog, p~prog_text, c~price, c~cust_type
FROM {{p}}carwash AS c
LEFT OUTER JOIN {{p}}washpgm AS p ON p~wash_prog = c~wash_prog
WHERE c~wash_date < @iv_from
AND c~wash_date <= @iv_to
AND c~wash_prog IN @it_prog
INTO CORRESPONDING FIELDS OF TABLE @rt_raw.
ENDMETHOD.
METHOD aggregate.
LOOP AT it_raw INTO DATA(ls_raw).
IF NOT line_exists( rt_lines[ wash_prog = ls_raw-wash_prog ] ).
APPEND VALUE #( wash_prog = ls_raw-wash_prog
prog_text = ls_raw-prog_text ) TO rt_lines.
ENDIF.
ASSIGN rt_lines[ wash_prog = ls_raw-wash_prog ] TO FIELD-SYMBOL(<ls_line>).
<ls_line>-washes = <ls_line>-washes + 1.
<ls_line>-revenue = <ls_line>-revenue + ls_raw-price.
IF ls_raw-cust_type = 'VIP'.
<ls_line>-vip_washes = <ls_line>-vip_washes + 1.
<ls_line>-vip_revenue = <ls_line>-vip_revenue + ls_raw-price.
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD display.
TRY.
cl_salv_table=>factory(
IMPORTING r_salv_table = DATA(lo_alv)
CHANGING t_table = ct_lines ).
lo_alv->display( ).
CATCH cx_salv_msg INTO DATA(lx_error).
MESSAGE lx_error TYPE 'I' DISPLAY LIKE 'E'.
ENDTRY.
ENDMETHOD.
ENDCLASS.
START-OF-SELECTION.
DATA(go_report) = NEW lcl_report( ).
DATA(gt_lines) = go_report->collect( iv_from = p_from
iv_to = p_to
it_prog = s_prog[] ).
go_report->display( CHANGING ct_lines = gt_lines ).
CLASS ltc_report DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
PRIVATE SECTION.
CLASS-DATA go_env TYPE REF TO if_osql_test_environment.
CLASS-METHODS class_setup.
CLASS-METHODS class_teardown.
METHODS totals_per_program FOR TESTING.
METHODS program_filter FOR TESTING.
ENDCLASS.
CLASS ltc_report IMPLEMENTATION.
METHOD class_setup.
go_env = cl_osql_test_environment=>create(
i_dependency_list = VALUE #( ( '{{P}}CARWASH' ) ( '{{P}}WASHPGM' ) ) ).
DATA lt_carwash TYPE STANDARD TABLE OF {{p}}carwash WITH EMPTY KEY.
lt_carwash = VALUE #(
( wash_id = 1 wash_prog = 'A' wash_date = '20260101' price = 10 cust_type = 'STD' )
( wash_id = 2 wash_prog = 'A' wash_date = '20260102' price = 5 cust_type = 'VIP' )
( wash_id = 3 wash_prog = 'B' wash_date = '20260101' price = 40 cust_type = 'STD' ) ).
go_env->insert_test_data( lt_carwash ).
DATA lt_prog TYPE STANDARD TABLE OF {{p}}washpgm WITH EMPTY KEY.
lt_prog = VALUE #( ( wash_prog = 'A' prog_text = 'Alpha' )
( wash_prog = 'B' prog_text = 'Beta' ) ).
go_env->insert_test_data( lt_prog ).
ENDMETHOD.
METHOD class_teardown.
go_env->destroy( ).
ENDMETHOD.
METHOD totals_per_program.
DATA(lt_lines) = NEW lcl_report( )->collect( iv_from = '20260101'
iv_to = '20260131'
it_prog = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'B' act = lt_lines[ 1 ]-wash_prog ).
cl_abap_unit_assert=>assert_equals( exp = 'Beta' act = lt_lines[ 1 ]-prog_text ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = lt_lines[ 2 ]-washes ).
cl_abap_unit_assert=>assert_equals( exp = CONV {{p}}carwash-price( 15 ) act = lt_lines[ 2 ]-revenue ).
ENDMETHOD.
METHOD program_filter.
DATA(lt_lines) = NEW lcl_report( )->collect(
iv_from = '20260101'
iv_to = '20260131'
it_prog = VALUE #( ( sign = 'I' option = 'EQ' low = 'A' ) ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lt_lines[ 1 ]-vip_washes ).
ENDMETHOD.
ENDCLASS.

View File

@@ -0,0 +1,157 @@
REPORT {{p}}carwash_rpt.
DATA gv_prog TYPE {{p}}carwash-wash_prog.
PARAMETERS: p_from TYPE d OBLIGATORY,
p_to TYPE d OBLIGATORY.
SELECT-OPTIONS: s_prog FOR gv_prog.
CLASS lcl_report DEFINITION FINAL.
PUBLIC SECTION.
TYPES:
BEGIN OF ty_line,
wash_prog TYPE {{p}}carwash-wash_prog,
prog_text TYPE {{p}}washpgm-prog_text,
washes TYPE i,
revenue TYPE {{p}}carwash-price,
vip_washes TYPE i,
vip_revenue TYPE {{p}}carwash-price,
END OF ty_line,
tt_line TYPE STANDARD TABLE OF ty_line WITH EMPTY KEY,
tt_prog TYPE RANGE OF {{p}}carwash-wash_prog.
METHODS collect
IMPORTING iv_from TYPE d
iv_to TYPE d
it_prog TYPE tt_prog
RETURNING VALUE(rt_lines) TYPE tt_line.
METHODS display
CHANGING ct_lines TYPE tt_line.
PRIVATE SECTION.
TYPES:
BEGIN OF ty_raw,
wash_prog TYPE {{p}}carwash-wash_prog,
prog_text TYPE {{p}}washpgm-prog_text,
price TYPE {{p}}carwash-price,
cust_type TYPE {{p}}carwash-cust_type,
END OF ty_raw,
tt_raw TYPE STANDARD TABLE OF ty_raw WITH EMPTY KEY.
METHODS read_washes
IMPORTING iv_from TYPE d
iv_to TYPE d
it_prog TYPE tt_prog
RETURNING VALUE(rt_raw) TYPE tt_raw.
METHODS aggregate
IMPORTING it_raw TYPE tt_raw
RETURNING VALUE(rt_lines) TYPE tt_line.
ENDCLASS.
CLASS lcl_report IMPLEMENTATION.
METHOD collect.
rt_lines = aggregate( read_washes( iv_from = iv_from
iv_to = iv_to
it_prog = it_prog ) ).
SORT rt_lines BY revenue DESCENDING.
ENDMETHOD.
METHOD read_washes.
SELECT c~wash_prog, p~prog_text, c~price, c~cust_type
FROM {{p}}carwash AS c
LEFT OUTER JOIN {{p}}washpgm AS p ON p~wash_prog = c~wash_prog
WHERE c~wash_date >= @iv_from
OR c~wash_date <= @iv_to
AND c~wash_prog IN @it_prog
INTO CORRESPONDING FIELDS OF TABLE @rt_raw.
ENDMETHOD.
METHOD aggregate.
LOOP AT it_raw INTO DATA(ls_raw).
IF NOT line_exists( rt_lines[ wash_prog = ls_raw-wash_prog ] ).
APPEND VALUE #( wash_prog = ls_raw-wash_prog
prog_text = ls_raw-prog_text ) TO rt_lines.
ENDIF.
ASSIGN rt_lines[ wash_prog = ls_raw-wash_prog ] TO FIELD-SYMBOL(<ls_line>).
<ls_line>-washes = <ls_line>-washes + 1.
<ls_line>-revenue = <ls_line>-revenue + ls_raw-price.
IF ls_raw-cust_type = 'VIP'.
<ls_line>-vip_washes = <ls_line>-vip_washes + 1.
<ls_line>-vip_revenue = <ls_line>-vip_revenue + ls_raw-price.
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD display.
TRY.
cl_salv_table=>factory(
IMPORTING r_salv_table = DATA(lo_alv)
CHANGING t_table = ct_lines ).
lo_alv->display( ).
CATCH cx_salv_msg INTO DATA(lx_error).
MESSAGE lx_error TYPE 'I' DISPLAY LIKE 'E'.
ENDTRY.
ENDMETHOD.
ENDCLASS.
START-OF-SELECTION.
DATA(go_report) = NEW lcl_report( ).
DATA(gt_lines) = go_report->collect( iv_from = p_from
iv_to = p_to
it_prog = s_prog[] ).
go_report->display( CHANGING ct_lines = gt_lines ).
CLASS ltc_report DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
PRIVATE SECTION.
CLASS-DATA go_env TYPE REF TO if_osql_test_environment.
CLASS-METHODS class_setup.
CLASS-METHODS class_teardown.
METHODS totals_per_program FOR TESTING.
METHODS program_filter FOR TESTING.
ENDCLASS.
CLASS ltc_report IMPLEMENTATION.
METHOD class_setup.
go_env = cl_osql_test_environment=>create(
i_dependency_list = VALUE #( ( '{{P}}CARWASH' ) ( '{{P}}WASHPGM' ) ) ).
DATA lt_carwash TYPE STANDARD TABLE OF {{p}}carwash WITH EMPTY KEY.
lt_carwash = VALUE #(
( wash_id = 1 wash_prog = 'A' wash_date = '20260101' price = 10 cust_type = 'STD' )
( wash_id = 2 wash_prog = 'A' wash_date = '20260102' price = 5 cust_type = 'VIP' )
( wash_id = 3 wash_prog = 'B' wash_date = '20260101' price = 40 cust_type = 'STD' ) ).
go_env->insert_test_data( lt_carwash ).
DATA lt_prog TYPE STANDARD TABLE OF {{p}}washpgm WITH EMPTY KEY.
lt_prog = VALUE #( ( wash_prog = 'A' prog_text = 'Alpha' )
( wash_prog = 'B' prog_text = 'Beta' ) ).
go_env->insert_test_data( lt_prog ).
ENDMETHOD.
METHOD class_teardown.
go_env->destroy( ).
ENDMETHOD.
METHOD totals_per_program.
DATA(lt_lines) = NEW lcl_report( )->collect( iv_from = '20260101'
iv_to = '20260131'
it_prog = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'B' act = lt_lines[ 1 ]-wash_prog ).
cl_abap_unit_assert=>assert_equals( exp = 'Beta' act = lt_lines[ 1 ]-prog_text ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = lt_lines[ 2 ]-washes ).
cl_abap_unit_assert=>assert_equals( exp = CONV {{p}}carwash-price( 15 ) act = lt_lines[ 2 ]-revenue ).
ENDMETHOD.
METHOD program_filter.
DATA(lt_lines) = NEW lcl_report( )->collect(
iv_from = '20260101'
iv_to = '20260131'
it_prog = VALUE #( ( sign = 'I' option = 'EQ' low = 'A' ) ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lt_lines[ 1 ]-vip_washes ).
ENDMETHOD.
ENDCLASS.

View File

@@ -0,0 +1,157 @@
REPORT {{p}}carwash_rpt.
DATA gv_prog TYPE {{p}}carwash-wash_prog.
PARAMETERS: p_from TYPE d OBLIGATORY,
p_to TYPE d OBLIGATORY.
SELECT-OPTIONS: s_prog FOR gv_prog.
CLASS lcl_report DEFINITION FINAL.
PUBLIC SECTION.
TYPES:
BEGIN OF ty_line,
wash_prog TYPE {{p}}carwash-wash_prog,
prog_text TYPE {{p}}washpgm-prog_text,
washes TYPE i,
revenue TYPE {{p}}carwash-price,
vip_washes TYPE i,
vip_revenue TYPE {{p}}carwash-price,
END OF ty_line,
tt_line TYPE STANDARD TABLE OF ty_line WITH EMPTY KEY,
tt_prog TYPE RANGE OF {{p}}carwash-wash_prog.
METHODS collect
IMPORTING iv_from TYPE d
iv_to TYPE d
it_prog TYPE tt_prog
RETURNING VALUE(rt_lines) TYPE tt_line.
METHODS display
CHANGING ct_lines TYPE tt_line.
PRIVATE SECTION.
TYPES:
BEGIN OF ty_raw,
wash_prog TYPE {{p}}carwash-wash_prog,
prog_text TYPE {{p}}washpgm-prog_text,
price TYPE {{p}}carwash-price,
cust_type TYPE {{p}}carwash-cust_type,
END OF ty_raw,
tt_raw TYPE STANDARD TABLE OF ty_raw WITH EMPTY KEY.
METHODS read_washes
IMPORTING iv_from TYPE d
iv_to TYPE d
it_prog TYPE tt_prog
RETURNING VALUE(rt_raw) TYPE tt_raw.
METHODS aggregate
IMPORTING it_raw TYPE tt_raw
RETURNING VALUE(rt_lines) TYPE tt_line.
ENDCLASS.
CLASS lcl_report IMPLEMENTATION.
METHOD collect.
rt_lines = aggregate( read_washes( iv_from = iv_from
iv_to = iv_to
it_prog = it_prog ) ).
SORT rt_lines BY revenue DESCENDING.
ENDMETHOD.
METHOD read_washes.
SELECT c~wash_prog, p~prog_text, c~price, c~cust_type
FROM {{p}}carwash AS c
LEFT OUTER JOIN {{p}}washpgm AS p ON p~wash_prog = c~wash_prog
WHERE c~wash_date >= @iv_from
AND c~wash_date <= @iv_to
AND c~wash_prog IN @it_prog
INTO CORRESPONDING FIELDS OF TABLE @rt_raw.
ENDMETHOD.
METHOD aggregate.
LOOP AT it_raw INTO DATA(ls_raw).
IF NOT line_exists( rt_lines[ wash_prog = ls_raw-wash_prog ] ).
APPEND VALUE #( wash_prog = ls_raw-wash_prog
prog_text = ls_raw-prog_text ) TO rt_lines.
ENDIF.
ASSIGN rt_lines[ wash_prog = ls_raw-wash_prog ] TO FIELD-SYMBOL(<ls_line>).
<ls_line>-washes = <ls_line>-washes + 1.
<ls_line>-revenue = <ls_line>-revenue - ls_raw-price.
IF ls_raw-cust_type = 'VIP'.
<ls_line>-vip_washes = <ls_line>-vip_washes + 1.
<ls_line>-vip_revenue = <ls_line>-vip_revenue + ls_raw-price.
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD display.
TRY.
cl_salv_table=>factory(
IMPORTING r_salv_table = DATA(lo_alv)
CHANGING t_table = ct_lines ).
lo_alv->display( ).
CATCH cx_salv_msg INTO DATA(lx_error).
MESSAGE lx_error TYPE 'I' DISPLAY LIKE 'E'.
ENDTRY.
ENDMETHOD.
ENDCLASS.
START-OF-SELECTION.
DATA(go_report) = NEW lcl_report( ).
DATA(gt_lines) = go_report->collect( iv_from = p_from
iv_to = p_to
it_prog = s_prog[] ).
go_report->display( CHANGING ct_lines = gt_lines ).
CLASS ltc_report DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
PRIVATE SECTION.
CLASS-DATA go_env TYPE REF TO if_osql_test_environment.
CLASS-METHODS class_setup.
CLASS-METHODS class_teardown.
METHODS totals_per_program FOR TESTING.
METHODS program_filter FOR TESTING.
ENDCLASS.
CLASS ltc_report IMPLEMENTATION.
METHOD class_setup.
go_env = cl_osql_test_environment=>create(
i_dependency_list = VALUE #( ( '{{P}}CARWASH' ) ( '{{P}}WASHPGM' ) ) ).
DATA lt_carwash TYPE STANDARD TABLE OF {{p}}carwash WITH EMPTY KEY.
lt_carwash = VALUE #(
( wash_id = 1 wash_prog = 'A' wash_date = '20260101' price = 10 cust_type = 'STD' )
( wash_id = 2 wash_prog = 'A' wash_date = '20260102' price = 5 cust_type = 'VIP' )
( wash_id = 3 wash_prog = 'B' wash_date = '20260101' price = 40 cust_type = 'STD' ) ).
go_env->insert_test_data( lt_carwash ).
DATA lt_prog TYPE STANDARD TABLE OF {{p}}washpgm WITH EMPTY KEY.
lt_prog = VALUE #( ( wash_prog = 'A' prog_text = 'Alpha' )
( wash_prog = 'B' prog_text = 'Beta' ) ).
go_env->insert_test_data( lt_prog ).
ENDMETHOD.
METHOD class_teardown.
go_env->destroy( ).
ENDMETHOD.
METHOD totals_per_program.
DATA(lt_lines) = NEW lcl_report( )->collect( iv_from = '20260101'
iv_to = '20260131'
it_prog = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'B' act = lt_lines[ 1 ]-wash_prog ).
cl_abap_unit_assert=>assert_equals( exp = 'Beta' act = lt_lines[ 1 ]-prog_text ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = lt_lines[ 2 ]-washes ).
cl_abap_unit_assert=>assert_equals( exp = CONV {{p}}carwash-price( 15 ) act = lt_lines[ 2 ]-revenue ).
ENDMETHOD.
METHOD program_filter.
DATA(lt_lines) = NEW lcl_report( )->collect(
iv_from = '20260101'
iv_to = '20260131'
it_prog = VALUE #( ( sign = 'I' option = 'EQ' low = 'A' ) ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lt_lines[ 1 ]-vip_washes ).
ENDMETHOD.
ENDCLASS.

View File

@@ -0,0 +1,157 @@
REPORT {{p}}carwash_rpt.
DATA gv_prog TYPE {{p}}carwash-wash_prog.
PARAMETERS: p_from TYPE d OBLIGATORY,
p_to TYPE d OBLIGATORY.
SELECT-OPTIONS: s_prog FOR gv_prog.
CLASS lcl_report DEFINITION FINAL.
PUBLIC SECTION.
TYPES:
BEGIN OF ty_line,
wash_prog TYPE {{p}}carwash-wash_prog,
prog_text TYPE {{p}}washpgm-prog_text,
washes TYPE i,
revenue TYPE {{p}}carwash-price,
vip_washes TYPE i,
vip_revenue TYPE {{p}}carwash-price,
END OF ty_line,
tt_line TYPE STANDARD TABLE OF ty_line WITH EMPTY KEY,
tt_prog TYPE RANGE OF {{p}}carwash-wash_prog.
METHODS collect
IMPORTING iv_from TYPE d
iv_to TYPE d
it_prog TYPE tt_prog
RETURNING VALUE(rt_lines) TYPE tt_line.
METHODS display
CHANGING ct_lines TYPE tt_line.
PRIVATE SECTION.
TYPES:
BEGIN OF ty_raw,
wash_prog TYPE {{p}}carwash-wash_prog,
prog_text TYPE {{p}}washpgm-prog_text,
price TYPE {{p}}carwash-price,
cust_type TYPE {{p}}carwash-cust_type,
END OF ty_raw,
tt_raw TYPE STANDARD TABLE OF ty_raw WITH EMPTY KEY.
METHODS read_washes
IMPORTING iv_from TYPE d
iv_to TYPE d
it_prog TYPE tt_prog
RETURNING VALUE(rt_raw) TYPE tt_raw.
METHODS aggregate
IMPORTING it_raw TYPE tt_raw
RETURNING VALUE(rt_lines) TYPE tt_line.
ENDCLASS.
CLASS lcl_report IMPLEMENTATION.
METHOD collect.
rt_lines = aggregate( read_washes( iv_from = iv_from
iv_to = iv_to
it_prog = it_prog ) ).
SORT rt_lines BY revenue DESCENDING.
ENDMETHOD.
METHOD read_washes.
SELECT c~wash_prog, p~prog_text, c~price, c~cust_type
FROM {{p}}carwash AS c
LEFT OUTER JOIN {{p}}washpgm AS p ON p~wash_prog = c~wash_prog
WHERE c~wash_date >= @iv_from
AND c~wash_date <= @iv_to
AND c~wash_prog IN @it_prog
INTO CORRESPONDING FIELDS OF TABLE @rt_raw.
ENDMETHOD.
METHOD aggregate.
LOOP AT it_raw INTO DATA(ls_raw).
IF NOT line_exists( rt_lines[ wash_prog = ls_raw-wash_prog ] ).
APPEND VALUE #( wash_prog = ls_raw-wash_prog
prog_text = ls_raw-prog_text ) TO rt_lines.
ENDIF.
ASSIGN rt_lines[ wash_prog = ls_raw-wash_prog ] TO FIELD-SYMBOL(<ls_line>).
<ls_line>-washes = <ls_line>-washes + 1.
<ls_line>-revenue = <ls_line>-revenue + ls_raw-price.
IF ls_raw-cust_type <> 'VIP'.
<ls_line>-vip_washes = <ls_line>-vip_washes + 1.
<ls_line>-vip_revenue = <ls_line>-vip_revenue + ls_raw-price.
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD display.
TRY.
cl_salv_table=>factory(
IMPORTING r_salv_table = DATA(lo_alv)
CHANGING t_table = ct_lines ).
lo_alv->display( ).
CATCH cx_salv_msg INTO DATA(lx_error).
MESSAGE lx_error TYPE 'I' DISPLAY LIKE 'E'.
ENDTRY.
ENDMETHOD.
ENDCLASS.
START-OF-SELECTION.
DATA(go_report) = NEW lcl_report( ).
DATA(gt_lines) = go_report->collect( iv_from = p_from
iv_to = p_to
it_prog = s_prog[] ).
go_report->display( CHANGING ct_lines = gt_lines ).
CLASS ltc_report DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
PRIVATE SECTION.
CLASS-DATA go_env TYPE REF TO if_osql_test_environment.
CLASS-METHODS class_setup.
CLASS-METHODS class_teardown.
METHODS totals_per_program FOR TESTING.
METHODS program_filter FOR TESTING.
ENDCLASS.
CLASS ltc_report IMPLEMENTATION.
METHOD class_setup.
go_env = cl_osql_test_environment=>create(
i_dependency_list = VALUE #( ( '{{P}}CARWASH' ) ( '{{P}}WASHPGM' ) ) ).
DATA lt_carwash TYPE STANDARD TABLE OF {{p}}carwash WITH EMPTY KEY.
lt_carwash = VALUE #(
( wash_id = 1 wash_prog = 'A' wash_date = '20260101' price = 10 cust_type = 'STD' )
( wash_id = 2 wash_prog = 'A' wash_date = '20260102' price = 5 cust_type = 'VIP' )
( wash_id = 3 wash_prog = 'B' wash_date = '20260101' price = 40 cust_type = 'STD' ) ).
go_env->insert_test_data( lt_carwash ).
DATA lt_prog TYPE STANDARD TABLE OF {{p}}washpgm WITH EMPTY KEY.
lt_prog = VALUE #( ( wash_prog = 'A' prog_text = 'Alpha' )
( wash_prog = 'B' prog_text = 'Beta' ) ).
go_env->insert_test_data( lt_prog ).
ENDMETHOD.
METHOD class_teardown.
go_env->destroy( ).
ENDMETHOD.
METHOD totals_per_program.
DATA(lt_lines) = NEW lcl_report( )->collect( iv_from = '20260101'
iv_to = '20260131'
it_prog = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'B' act = lt_lines[ 1 ]-wash_prog ).
cl_abap_unit_assert=>assert_equals( exp = 'Beta' act = lt_lines[ 1 ]-prog_text ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = lt_lines[ 2 ]-washes ).
cl_abap_unit_assert=>assert_equals( exp = CONV {{p}}carwash-price( 15 ) act = lt_lines[ 2 ]-revenue ).
ENDMETHOD.
METHOD program_filter.
DATA(lt_lines) = NEW lcl_report( )->collect(
iv_from = '20260101'
iv_to = '20260131'
it_prog = VALUE #( ( sign = 'I' option = 'EQ' low = 'A' ) ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lt_lines[ 1 ]-vip_washes ).
ENDMETHOD.
ENDCLASS.

View File

@@ -0,0 +1,157 @@
REPORT {{p}}carwash_rpt.
DATA gv_prog TYPE {{p}}carwash-wash_prog.
PARAMETERS: p_from TYPE d OBLIGATORY,
p_to TYPE d OBLIGATORY.
SELECT-OPTIONS: s_prog FOR gv_prog.
CLASS lcl_report DEFINITION FINAL.
PUBLIC SECTION.
TYPES:
BEGIN OF ty_line,
wash_prog TYPE {{p}}carwash-wash_prog,
prog_text TYPE {{p}}washpgm-prog_text,
washes TYPE i,
revenue TYPE {{p}}carwash-price,
vip_washes TYPE i,
vip_revenue TYPE {{p}}carwash-price,
END OF ty_line,
tt_line TYPE STANDARD TABLE OF ty_line WITH EMPTY KEY,
tt_prog TYPE RANGE OF {{p}}carwash-wash_prog.
METHODS collect
IMPORTING iv_from TYPE d
iv_to TYPE d
it_prog TYPE tt_prog
RETURNING VALUE(rt_lines) TYPE tt_line.
METHODS display
CHANGING ct_lines TYPE tt_line.
PRIVATE SECTION.
TYPES:
BEGIN OF ty_raw,
wash_prog TYPE {{p}}carwash-wash_prog,
prog_text TYPE {{p}}washpgm-prog_text,
price TYPE {{p}}carwash-price,
cust_type TYPE {{p}}carwash-cust_type,
END OF ty_raw,
tt_raw TYPE STANDARD TABLE OF ty_raw WITH EMPTY KEY.
METHODS read_washes
IMPORTING iv_from TYPE d
iv_to TYPE d
it_prog TYPE tt_prog
RETURNING VALUE(rt_raw) TYPE tt_raw.
METHODS aggregate
IMPORTING it_raw TYPE tt_raw
RETURNING VALUE(rt_lines) TYPE tt_line.
ENDCLASS.
CLASS lcl_report IMPLEMENTATION.
METHOD collect.
rt_lines = aggregate( read_washes( iv_from = iv_from
iv_to = iv_to
it_prog = it_prog ) ).
SORT rt_lines BY revenue DESCENDING.
ENDMETHOD.
METHOD read_washes.
SELECT c~wash_prog, p~prog_text, c~price, c~cust_type
FROM {{p}}carwash AS c
LEFT OUTER JOIN {{p}}washpgm AS p ON p~wash_prog = c~wash_prog
WHERE c~wash_date >= @iv_from
AND c~wash_date <= @iv_to
AND c~wash_prog IN @it_prog
INTO CORRESPONDING FIELDS OF TABLE @rt_raw.
ENDMETHOD.
METHOD aggregate.
LOOP AT it_raw INTO DATA(ls_raw).
IF NOT line_exists( rt_lines[ wash_prog = ls_raw-wash_prog ] ).
APPEND VALUE #( wash_prog = ls_raw-wash_prog
prog_text = ls_raw-prog_text ) TO rt_lines.
ENDIF.
ASSIGN rt_lines[ wash_prog = ls_raw-wash_prog ] TO FIELD-SYMBOL(<ls_line>).
<ls_line>-washes = <ls_line>-washes + 1.
<ls_line>-revenue = <ls_line>-revenue + ls_raw-price.
IF ls_raw-cust_type = 'VIP'.
<ls_line>-vip_washes = <ls_line>-vip_washes - 1.
<ls_line>-vip_revenue = <ls_line>-vip_revenue + ls_raw-price.
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD display.
TRY.
cl_salv_table=>factory(
IMPORTING r_salv_table = DATA(lo_alv)
CHANGING t_table = ct_lines ).
lo_alv->display( ).
CATCH cx_salv_msg INTO DATA(lx_error).
MESSAGE lx_error TYPE 'I' DISPLAY LIKE 'E'.
ENDTRY.
ENDMETHOD.
ENDCLASS.
START-OF-SELECTION.
DATA(go_report) = NEW lcl_report( ).
DATA(gt_lines) = go_report->collect( iv_from = p_from
iv_to = p_to
it_prog = s_prog[] ).
go_report->display( CHANGING ct_lines = gt_lines ).
CLASS ltc_report DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
PRIVATE SECTION.
CLASS-DATA go_env TYPE REF TO if_osql_test_environment.
CLASS-METHODS class_setup.
CLASS-METHODS class_teardown.
METHODS totals_per_program FOR TESTING.
METHODS program_filter FOR TESTING.
ENDCLASS.
CLASS ltc_report IMPLEMENTATION.
METHOD class_setup.
go_env = cl_osql_test_environment=>create(
i_dependency_list = VALUE #( ( '{{P}}CARWASH' ) ( '{{P}}WASHPGM' ) ) ).
DATA lt_carwash TYPE STANDARD TABLE OF {{p}}carwash WITH EMPTY KEY.
lt_carwash = VALUE #(
( wash_id = 1 wash_prog = 'A' wash_date = '20260101' price = 10 cust_type = 'STD' )
( wash_id = 2 wash_prog = 'A' wash_date = '20260102' price = 5 cust_type = 'VIP' )
( wash_id = 3 wash_prog = 'B' wash_date = '20260101' price = 40 cust_type = 'STD' ) ).
go_env->insert_test_data( lt_carwash ).
DATA lt_prog TYPE STANDARD TABLE OF {{p}}washpgm WITH EMPTY KEY.
lt_prog = VALUE #( ( wash_prog = 'A' prog_text = 'Alpha' )
( wash_prog = 'B' prog_text = 'Beta' ) ).
go_env->insert_test_data( lt_prog ).
ENDMETHOD.
METHOD class_teardown.
go_env->destroy( ).
ENDMETHOD.
METHOD totals_per_program.
DATA(lt_lines) = NEW lcl_report( )->collect( iv_from = '20260101'
iv_to = '20260131'
it_prog = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'B' act = lt_lines[ 1 ]-wash_prog ).
cl_abap_unit_assert=>assert_equals( exp = 'Beta' act = lt_lines[ 1 ]-prog_text ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = lt_lines[ 2 ]-washes ).
cl_abap_unit_assert=>assert_equals( exp = CONV {{p}}carwash-price( 15 ) act = lt_lines[ 2 ]-revenue ).
ENDMETHOD.
METHOD program_filter.
DATA(lt_lines) = NEW lcl_report( )->collect(
iv_from = '20260101'
iv_to = '20260131'
it_prog = VALUE #( ( sign = 'I' option = 'EQ' low = 'A' ) ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lt_lines[ 1 ]-vip_washes ).
ENDMETHOD.
ENDCLASS.