Step F first pass: 81/92 accepted; budget floor 60 calls; rejected slots moved for regeneration

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014aUaQeLnwbb1zTpN7kHeat
This commit is contained in:
Kral
2026-10-03 12:10:52 +02:00
parent d3250acfb8
commit 39769afce8
741 changed files with 40573 additions and 317 deletions

View File

@@ -0,0 +1,131 @@
REPORT {{p}}news_dist_old.
TYPES ty_rate TYPE p LENGTH 8 DECIMALS 2.
TYPES: BEGIN OF ty_line,
agent TYPE {{p}}agent-agent_id,
name TYPE {{p}}agent-agent_name,
district TYPE {{p}}agent-district,
copies TYPE i,
returned TYPE i,
rate TYPE ty_rate,
END OF ty_line.
TYPES tt_line TYPE STANDARD TABLE OF ty_line WITH EMPTY KEY.
TYPES ty_date TYPE d.
TYPES tt_date TYPE RANGE OF ty_date.
TYPES ty_dist TYPE c LENGTH 4.
TYPES tt_dist TYPE RANGE OF ty_dist.
DATA gv_date TYPE ty_date.
DATA gv_dist TYPE ty_dist.
SELECT-OPTIONS s_date FOR gv_date.
SELECT-OPTIONS s_dist FOR gv_dist.
CLASS lcl_report DEFINITION FINAL.
PUBLIC SECTION.
METHODS select_lines
IMPORTING it_date TYPE tt_date
it_dist TYPE tt_dist
RETURNING VALUE(rt_lines) TYPE tt_line.
METHODS display
CHANGING ct_lines TYPE tt_line.
PRIVATE SECTION.
METHODS add_rate
CHANGING cs_line TYPE ty_line.
ENDCLASS.
CLASS lcl_report IMPLEMENTATION.
METHOD select_lines.
SELECT a~agent_id AS agent,
a~agent_name AS name,
a~district AS district,
SUM( d~del_copies ) AS copies,
SUM( d~ret_copies ) AS returned
FROM {{p}}agent AS a
INNER JOIN {{p}}deliv AS d ON d~agent_id = a~agent_id
WHERE d~del_date IN @it_date
AND a~district IN @it_dist
GROUP BY a~agent_id, a~agent_name, a~district
INTO CORRESPONDING FIELDS OF TABLE @rt_lines.
LOOP AT rt_lines ASSIGNING FIELD-SYMBOL(<ls_line>).
add_rate( CHANGING cs_line = <ls_line> ).
ENDLOOP.
SORT rt_lines BY rate DESCENDING agent ASCENDING.
ENDMETHOD.
METHOD add_rate.
DATA lv_copies TYPE p LENGTH 15 DECIMALS 2.
lv_copies = cs_line-copies.
IF lv_copies > 0.
cs_line-rate = cs_line-returned * 100 / lv_copies.
ELSE.
cs_line-rate = 0.
ENDIF.
ENDMETHOD.
METHOD display.
TRY.
cl_salv_table=>factory( IMPORTING r_salv_table = DATA(lo_alv)
CHANGING t_table = ct_lines ).
lo_alv->display( ).
CATCH cx_salv_msg INTO DATA(lx_error).
MESSAGE lx_error TYPE 'I' DISPLAY LIKE 'E'.
ENDTRY.
ENDMETHOD.
ENDCLASS.
START-OF-SELECTION.
DATA(go_report) = NEW lcl_report( ).
DATA(gt_lines) = go_report->select_lines( it_date = s_date[]
it_dist = s_dist[] ).
go_report->display( CHANGING ct_lines = gt_lines ).
CLASS ltc_report DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
PRIVATE SECTION.
CLASS-DATA go_env TYPE REF TO if_osql_test_environment.
CLASS-METHODS class_setup.
CLASS-METHODS class_teardown.
METHODS sums_per_agent FOR TESTING.
METHODS rate_with_zero_copies FOR TESTING.
ENDCLASS.
CLASS ltc_report IMPLEMENTATION.
METHOD class_setup.
go_env = cl_osql_test_environment=>create(
i_dependency_list = VALUE #( ( '{{P}}AGENT' ) ( '{{P}}DELIV' ) ) ).
DATA lt_agent TYPE STANDARD TABLE OF {{p}}agent WITH EMPTY KEY.
lt_agent = VALUE #( ( agent_id = 'A1' agent_name = 'One' district = 'N' )
( agent_id = 'A2' agent_name = 'Two' district = 'S' ) ).
go_env->insert_test_data( lt_agent ).
DATA lt_deliv TYPE STANDARD TABLE OF {{p}}deliv WITH EMPTY KEY.
lt_deliv = VALUE #( ( deliv_id = 1 agent_id = 'A1' del_date = '20260105' del_copies = 100 ret_copies = 5 )
( deliv_id = 2 agent_id = 'A1' del_date = '20260112' del_copies = 100 ret_copies = 15 )
( deliv_id = 3 agent_id = 'A2' del_date = '20260106' del_copies = 0 ret_copies = 0 ) ).
go_env->insert_test_data( lt_deliv ).
ENDMETHOD.
METHOD class_teardown.
go_env->destroy( ).
ENDMETHOD.
METHOD sums_per_agent.
DATA(lt_lines) = NEW lcl_report( )->select_lines( it_date = VALUE tt_date( )
it_dist = VALUE tt_dist( ) ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'A1' act = lt_lines[ 1 ]-agent ).
cl_abap_unit_assert=>assert_equals( exp = 200 act = lt_lines[ 1 ]-copies ).
cl_abap_unit_assert=>assert_equals( exp = 20 act = lt_lines[ 1 ]-returned ).
cl_abap_unit_assert=>assert_equals( exp = '10.00' act = |{ lt_lines[ 1 ]-rate }| ).
ENDMETHOD.
METHOD rate_with_zero_copies.
DATA(lt_lines) = NEW lcl_report( )->select_lines( it_date = VALUE tt_date( )
it_dist = VALUE tt_dist( ) ).
cl_abap_unit_assert=>assert_equals( exp = 'A2' act = lt_lines[ 2 ]-agent ).
cl_abap_unit_assert=>assert_equals( exp = 0 act = lt_lines[ 2 ]-copies ).
cl_abap_unit_assert=>assert_equals( exp = '0.00' act = |{ lt_lines[ 2 ]-rate }| ).
ENDMETHOD.
ENDCLASS.