Step F first pass: 81/92 accepted; budget floor 60 calls; rejected slots moved for regeneration

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014aUaQeLnwbb1zTpN7kHeat
This commit is contained in:
Kral
2026-10-03 12:10:52 +02:00
parent d3250acfb8
commit 39769afce8
741 changed files with 40573 additions and 317 deletions

View File

@@ -0,0 +1,149 @@
REPORT {{p}}fleet_cost_old.
PARAMETERS p_from TYPE d OBLIGATORY.
PARAMETERS p_to TYPE d OBLIGATORY.
DATA gv_cat TYPE {{p}}vehicle-category.
SELECT-OPTIONS s_cat FOR gv_cat.
CLASS lcl_fleet DEFINITION FINAL.
PUBLIC SECTION.
TYPES:
BEGIN OF ty_line,
vehicle_id TYPE {{p}}vehicle-vehicle_id,
plate TYPE {{p}}vehicle-plate,
category TYPE {{p}}vehicle-category,
distance TYPE {{p}}trip-distance_km,
fuel_cost TYPE {{p}}trip-toll_fee,
toll_cost TYPE {{p}}trip-toll_fee,
total_cost TYPE {{p}}trip-toll_fee,
cost_per_km TYPE p LENGTH 15 DECIMALS 3,
END OF ty_line,
tt_line TYPE STANDARD TABLE OF ty_line WITH EMPTY KEY,
tt_cat TYPE RANGE OF {{p}}vehicle-category.
CLASS-METHODS select_costs
IMPORTING iv_from TYPE d
iv_to TYPE d
it_cat TYPE tt_cat
RETURNING VALUE(rt_lines) TYPE tt_line.
CLASS-METHODS show
CHANGING ct_lines TYPE tt_line.
PRIVATE SECTION.
CLASS-METHODS cost_per_km
IMPORTING is_line TYPE ty_line
RETURNING VALUE(rv_value) TYPE ty_line-cost_per_km.
ENDCLASS.
CLASS lcl_fleet IMPLEMENTATION.
METHOD select_costs.
SELECT v~vehicle_id,
v~plate,
v~category,
SUM( t~distance_km ) AS distance,
SUM( t~fuel_liters * t~fuel_price ) AS fuel_cost,
SUM( t~toll_fee ) AS toll_cost
FROM {{p}}vehicle AS v
INNER JOIN {{p}}trip AS t ON t~vehicle_id = v~vehicle_id
WHERE t~trip_date BETWEEN @iv_from AND @iv_to
OR v~category IN @it_cat
GROUP BY v~vehicle_id, v~plate, v~category
INTO TABLE @DATA(lt_sums).
LOOP AT lt_sums INTO DATA(ls_sum).
DATA(ls_line) = VALUE ty_line(
vehicle_id = ls_sum-vehicle_id
plate = ls_sum-plate
category = ls_sum-category
distance = ls_sum-distance
fuel_cost = ls_sum-fuel_cost
toll_cost = ls_sum-toll_cost
total_cost = ls_sum-fuel_cost + ls_sum-toll_cost ).
ls_line-cost_per_km = cost_per_km( ls_line ).
APPEND ls_line TO rt_lines.
ENDLOOP.
SORT rt_lines BY total_cost DESCENDING.
ENDMETHOD.
METHOD cost_per_km.
IF is_line-distance > 0.
rv_value = ROUND( val = is_line-total_cost / is_line-distance dec = 3 ).
ENDIF.
ENDMETHOD.
METHOD show.
TRY.
cl_salv_table=>factory( IMPORTING r_salv_table = DATA(lo_alv)
CHANGING t_table = ct_lines ).
lo_alv->display( ).
CATCH cx_salv_msg INTO DATA(lx_error).
MESSAGE lx_error TYPE 'I' DISPLAY LIKE 'E'.
ENDTRY.
ENDMETHOD.
ENDCLASS.
START-OF-SELECTION.
DATA(gt_lines) = lcl_fleet=>select_costs( iv_from = p_from
iv_to = p_to
it_cat = s_cat[] ).
lcl_fleet=>show( CHANGING ct_lines = gt_lines ).
CLASS ltc_fleet DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
PRIVATE SECTION.
CLASS-DATA go_env TYPE REF TO if_osql_test_environment.
CLASS-METHODS class_setup.
CLASS-METHODS class_teardown.
METHODS totals_per_vehicle FOR TESTING.
METHODS period_filter FOR TESTING.
METHODS category_filter FOR TESTING.
ENDCLASS.
CLASS ltc_fleet IMPLEMENTATION.
METHOD class_setup.
go_env = cl_osql_test_environment=>create(
i_dependency_list = VALUE #( ( '{{P}}VEHICLE' ) ( '{{P}}TRIP' ) ) ).
DATA lt_vehicle TYPE STANDARD TABLE OF {{p}}vehicle WITH EMPTY KEY.
lt_vehicle = VALUE #( ( vehicle_id = 'V1' plate = 'AAA' category = 'VAN' )
( vehicle_id = 'V2' plate = 'BBB' category = 'TRUCK' ) ).
go_env->insert_test_data( lt_vehicle ).
DATA lt_trip TYPE STANDARD TABLE OF {{p}}trip WITH EMPTY KEY.
lt_trip = VALUE #( ( trip_id = 1 vehicle_id = 'V1' trip_date = '20260105'
distance_km = 100 fuel_liters = 10 fuel_price = 2 toll_fee = 1 )
( trip_id = 2 vehicle_id = 'V2' trip_date = '20260106'
distance_km = 50 fuel_liters = 5 fuel_price = 2 toll_fee = 0 ) ).
go_env->insert_test_data( lt_trip ).
ENDMETHOD.
METHOD class_teardown.
go_env->destroy( ).
ENDMETHOD.
METHOD totals_per_vehicle.
DATA(lt_lines) = lcl_fleet=>select_costs( iv_from = '20260101'
iv_to = '20260131'
it_cat = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'V1' act = lt_lines[ 1 ]-vehicle_id ).
cl_abap_unit_assert=>assert_equals( exp = CONV {{p}}trip-toll_fee( 21 ) act = lt_lines[ 1 ]-total_cost ).
cl_abap_unit_assert=>assert_equals( exp = 'V2' act = lt_lines[ 2 ]-vehicle_id ).
ENDMETHOD.
METHOD period_filter.
DATA(lt_lines) = lcl_fleet=>select_costs( iv_from = '20260106'
iv_to = '20260106'
it_cat = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'V2' act = lt_lines[ 1 ]-vehicle_id ).
ENDMETHOD.
METHOD category_filter.
DATA(lt_lines) = lcl_fleet=>select_costs(
iv_from = '20260101'
iv_to = '20260131'
it_cat = VALUE #( ( sign = 'I' option = 'EQ' low = 'TRUCK' ) ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'V2' act = lt_lines[ 1 ]-vehicle_id ).
ENDMETHOD.
ENDCLASS.

View File

@@ -0,0 +1,149 @@
REPORT {{p}}fleet_cost_old.
PARAMETERS p_from TYPE d OBLIGATORY.
PARAMETERS p_to TYPE d OBLIGATORY.
DATA gv_cat TYPE {{p}}vehicle-category.
SELECT-OPTIONS s_cat FOR gv_cat.
CLASS lcl_fleet DEFINITION FINAL.
PUBLIC SECTION.
TYPES:
BEGIN OF ty_line,
vehicle_id TYPE {{p}}vehicle-vehicle_id,
plate TYPE {{p}}vehicle-plate,
category TYPE {{p}}vehicle-category,
distance TYPE {{p}}trip-distance_km,
fuel_cost TYPE {{p}}trip-toll_fee,
toll_cost TYPE {{p}}trip-toll_fee,
total_cost TYPE {{p}}trip-toll_fee,
cost_per_km TYPE p LENGTH 15 DECIMALS 3,
END OF ty_line,
tt_line TYPE STANDARD TABLE OF ty_line WITH EMPTY KEY,
tt_cat TYPE RANGE OF {{p}}vehicle-category.
CLASS-METHODS select_costs
IMPORTING iv_from TYPE d
iv_to TYPE d
it_cat TYPE tt_cat
RETURNING VALUE(rt_lines) TYPE tt_line.
CLASS-METHODS show
CHANGING ct_lines TYPE tt_line.
PRIVATE SECTION.
CLASS-METHODS cost_per_km
IMPORTING is_line TYPE ty_line
RETURNING VALUE(rv_value) TYPE ty_line-cost_per_km.
ENDCLASS.
CLASS lcl_fleet IMPLEMENTATION.
METHOD select_costs.
SELECT v~vehicle_id,
v~plate,
v~category,
SUM( t~distance_km ) AS distance,
SUM( t~fuel_liters * t~fuel_price ) AS fuel_cost,
SUM( t~toll_fee ) AS toll_cost
FROM {{p}}vehicle AS v
INNER JOIN {{p}}trip AS t ON t~vehicle_id = v~vehicle_id
WHERE t~trip_date BETWEEN @iv_from AND @iv_to
AND v~category IN @it_cat
GROUP BY v~vehicle_id, v~plate, v~category
INTO TABLE @DATA(lt_sums).
LOOP AT lt_sums INTO DATA(ls_sum).
DATA(ls_line) = VALUE ty_line(
vehicle_id = ls_sum-vehicle_id
plate = ls_sum-plate
category = ls_sum-category
distance = ls_sum-distance
fuel_cost = ls_sum-fuel_cost
toll_cost = ls_sum-toll_cost
total_cost = ls_sum-fuel_cost - ls_sum-toll_cost ).
ls_line-cost_per_km = cost_per_km( ls_line ).
APPEND ls_line TO rt_lines.
ENDLOOP.
SORT rt_lines BY total_cost DESCENDING.
ENDMETHOD.
METHOD cost_per_km.
IF is_line-distance > 0.
rv_value = ROUND( val = is_line-total_cost / is_line-distance dec = 3 ).
ENDIF.
ENDMETHOD.
METHOD show.
TRY.
cl_salv_table=>factory( IMPORTING r_salv_table = DATA(lo_alv)
CHANGING t_table = ct_lines ).
lo_alv->display( ).
CATCH cx_salv_msg INTO DATA(lx_error).
MESSAGE lx_error TYPE 'I' DISPLAY LIKE 'E'.
ENDTRY.
ENDMETHOD.
ENDCLASS.
START-OF-SELECTION.
DATA(gt_lines) = lcl_fleet=>select_costs( iv_from = p_from
iv_to = p_to
it_cat = s_cat[] ).
lcl_fleet=>show( CHANGING ct_lines = gt_lines ).
CLASS ltc_fleet DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
PRIVATE SECTION.
CLASS-DATA go_env TYPE REF TO if_osql_test_environment.
CLASS-METHODS class_setup.
CLASS-METHODS class_teardown.
METHODS totals_per_vehicle FOR TESTING.
METHODS period_filter FOR TESTING.
METHODS category_filter FOR TESTING.
ENDCLASS.
CLASS ltc_fleet IMPLEMENTATION.
METHOD class_setup.
go_env = cl_osql_test_environment=>create(
i_dependency_list = VALUE #( ( '{{P}}VEHICLE' ) ( '{{P}}TRIP' ) ) ).
DATA lt_vehicle TYPE STANDARD TABLE OF {{p}}vehicle WITH EMPTY KEY.
lt_vehicle = VALUE #( ( vehicle_id = 'V1' plate = 'AAA' category = 'VAN' )
( vehicle_id = 'V2' plate = 'BBB' category = 'TRUCK' ) ).
go_env->insert_test_data( lt_vehicle ).
DATA lt_trip TYPE STANDARD TABLE OF {{p}}trip WITH EMPTY KEY.
lt_trip = VALUE #( ( trip_id = 1 vehicle_id = 'V1' trip_date = '20260105'
distance_km = 100 fuel_liters = 10 fuel_price = 2 toll_fee = 1 )
( trip_id = 2 vehicle_id = 'V2' trip_date = '20260106'
distance_km = 50 fuel_liters = 5 fuel_price = 2 toll_fee = 0 ) ).
go_env->insert_test_data( lt_trip ).
ENDMETHOD.
METHOD class_teardown.
go_env->destroy( ).
ENDMETHOD.
METHOD totals_per_vehicle.
DATA(lt_lines) = lcl_fleet=>select_costs( iv_from = '20260101'
iv_to = '20260131'
it_cat = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'V1' act = lt_lines[ 1 ]-vehicle_id ).
cl_abap_unit_assert=>assert_equals( exp = CONV {{p}}trip-toll_fee( 21 ) act = lt_lines[ 1 ]-total_cost ).
cl_abap_unit_assert=>assert_equals( exp = 'V2' act = lt_lines[ 2 ]-vehicle_id ).
ENDMETHOD.
METHOD period_filter.
DATA(lt_lines) = lcl_fleet=>select_costs( iv_from = '20260106'
iv_to = '20260106'
it_cat = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'V2' act = lt_lines[ 1 ]-vehicle_id ).
ENDMETHOD.
METHOD category_filter.
DATA(lt_lines) = lcl_fleet=>select_costs(
iv_from = '20260101'
iv_to = '20260131'
it_cat = VALUE #( ( sign = 'I' option = 'EQ' low = 'TRUCK' ) ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'V2' act = lt_lines[ 1 ]-vehicle_id ).
ENDMETHOD.
ENDCLASS.

View File

@@ -0,0 +1,149 @@
REPORT {{p}}fleet_cost_old.
PARAMETERS p_from TYPE d OBLIGATORY.
PARAMETERS p_to TYPE d OBLIGATORY.
DATA gv_cat TYPE {{p}}vehicle-category.
SELECT-OPTIONS s_cat FOR gv_cat.
CLASS lcl_fleet DEFINITION FINAL.
PUBLIC SECTION.
TYPES:
BEGIN OF ty_line,
vehicle_id TYPE {{p}}vehicle-vehicle_id,
plate TYPE {{p}}vehicle-plate,
category TYPE {{p}}vehicle-category,
distance TYPE {{p}}trip-distance_km,
fuel_cost TYPE {{p}}trip-toll_fee,
toll_cost TYPE {{p}}trip-toll_fee,
total_cost TYPE {{p}}trip-toll_fee,
cost_per_km TYPE p LENGTH 15 DECIMALS 3,
END OF ty_line,
tt_line TYPE STANDARD TABLE OF ty_line WITH EMPTY KEY,
tt_cat TYPE RANGE OF {{p}}vehicle-category.
CLASS-METHODS select_costs
IMPORTING iv_from TYPE d
iv_to TYPE d
it_cat TYPE tt_cat
RETURNING VALUE(rt_lines) TYPE tt_line.
CLASS-METHODS show
CHANGING ct_lines TYPE tt_line.
PRIVATE SECTION.
CLASS-METHODS cost_per_km
IMPORTING is_line TYPE ty_line
RETURNING VALUE(rv_value) TYPE ty_line-cost_per_km.
ENDCLASS.
CLASS lcl_fleet IMPLEMENTATION.
METHOD select_costs.
SELECT v~vehicle_id,
v~plate,
v~category,
SUM( t~distance_km ) AS distance,
SUM( t~fuel_liters * t~fuel_price ) AS fuel_cost,
SUM( t~toll_fee ) AS toll_cost
FROM {{p}}vehicle AS v
INNER JOIN {{p}}trip AS t ON t~vehicle_id = v~vehicle_id
WHERE t~trip_date BETWEEN @iv_from AND @iv_to
AND v~category IN @it_cat
GROUP BY v~vehicle_id, v~plate, v~category
INTO TABLE @DATA(lt_sums).
LOOP AT lt_sums INTO DATA(ls_sum).
DATA(ls_line) = VALUE ty_line(
vehicle_id = ls_sum-vehicle_id
plate = ls_sum-plate
category = ls_sum-category
distance = ls_sum-distance
fuel_cost = ls_sum-fuel_cost
toll_cost = ls_sum-toll_cost
total_cost = ls_sum-fuel_cost + ls_sum-toll_cost ).
ls_line-cost_per_km = cost_per_km( ls_line ).
APPEND ls_line TO rt_lines.
ENDLOOP.
SORT rt_lines BY total_cost DESCENDING.
ENDMETHOD.
METHOD cost_per_km.
IF is_line-distance <= 0.
rv_value = ROUND( val = is_line-total_cost / is_line-distance dec = 3 ).
ENDIF.
ENDMETHOD.
METHOD show.
TRY.
cl_salv_table=>factory( IMPORTING r_salv_table = DATA(lo_alv)
CHANGING t_table = ct_lines ).
lo_alv->display( ).
CATCH cx_salv_msg INTO DATA(lx_error).
MESSAGE lx_error TYPE 'I' DISPLAY LIKE 'E'.
ENDTRY.
ENDMETHOD.
ENDCLASS.
START-OF-SELECTION.
DATA(gt_lines) = lcl_fleet=>select_costs( iv_from = p_from
iv_to = p_to
it_cat = s_cat[] ).
lcl_fleet=>show( CHANGING ct_lines = gt_lines ).
CLASS ltc_fleet DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
PRIVATE SECTION.
CLASS-DATA go_env TYPE REF TO if_osql_test_environment.
CLASS-METHODS class_setup.
CLASS-METHODS class_teardown.
METHODS totals_per_vehicle FOR TESTING.
METHODS period_filter FOR TESTING.
METHODS category_filter FOR TESTING.
ENDCLASS.
CLASS ltc_fleet IMPLEMENTATION.
METHOD class_setup.
go_env = cl_osql_test_environment=>create(
i_dependency_list = VALUE #( ( '{{P}}VEHICLE' ) ( '{{P}}TRIP' ) ) ).
DATA lt_vehicle TYPE STANDARD TABLE OF {{p}}vehicle WITH EMPTY KEY.
lt_vehicle = VALUE #( ( vehicle_id = 'V1' plate = 'AAA' category = 'VAN' )
( vehicle_id = 'V2' plate = 'BBB' category = 'TRUCK' ) ).
go_env->insert_test_data( lt_vehicle ).
DATA lt_trip TYPE STANDARD TABLE OF {{p}}trip WITH EMPTY KEY.
lt_trip = VALUE #( ( trip_id = 1 vehicle_id = 'V1' trip_date = '20260105'
distance_km = 100 fuel_liters = 10 fuel_price = 2 toll_fee = 1 )
( trip_id = 2 vehicle_id = 'V2' trip_date = '20260106'
distance_km = 50 fuel_liters = 5 fuel_price = 2 toll_fee = 0 ) ).
go_env->insert_test_data( lt_trip ).
ENDMETHOD.
METHOD class_teardown.
go_env->destroy( ).
ENDMETHOD.
METHOD totals_per_vehicle.
DATA(lt_lines) = lcl_fleet=>select_costs( iv_from = '20260101'
iv_to = '20260131'
it_cat = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'V1' act = lt_lines[ 1 ]-vehicle_id ).
cl_abap_unit_assert=>assert_equals( exp = CONV {{p}}trip-toll_fee( 21 ) act = lt_lines[ 1 ]-total_cost ).
cl_abap_unit_assert=>assert_equals( exp = 'V2' act = lt_lines[ 2 ]-vehicle_id ).
ENDMETHOD.
METHOD period_filter.
DATA(lt_lines) = lcl_fleet=>select_costs( iv_from = '20260106'
iv_to = '20260106'
it_cat = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'V2' act = lt_lines[ 1 ]-vehicle_id ).
ENDMETHOD.
METHOD category_filter.
DATA(lt_lines) = lcl_fleet=>select_costs(
iv_from = '20260101'
iv_to = '20260131'
it_cat = VALUE #( ( sign = 'I' option = 'EQ' low = 'TRUCK' ) ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'V2' act = lt_lines[ 1 ]-vehicle_id ).
ENDMETHOD.
ENDCLASS.

View File

@@ -0,0 +1,29 @@
{
"id": "G0190",
"pool": "eval",
"object_type": "PROG",
"category": "E",
"attempts": [
{
"stage": "bundle",
"errors": [
"hidden/fleet_hidden.clas.abap line 77: syntax error for release v758 (abaplint): Statement does not exist in the configured ABAP version(or a parser error), \"cl_abap_unit_assert\"",
"reference/fleet_cost_old.prog.abap line 138: syntax error for release v758 (abaplint): Statement does not exist in the configured ABAP version(or a parser error), \"cl_abap_unit_assert\""
],
"by_check": {
"abaplint": 2
}
},
{
"stage": "validate",
"oracle": 100.0,
"null": 0,
"mutation": {
"valid": 4,
"killed": 3,
"ok": true
}
}
],
"accepted": true
}

View File

@@ -0,0 +1,116 @@
CLASS {{p}}fleet_hidden DEFINITION PUBLIC FINAL CREATE PUBLIC
FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
PRIVATE SECTION.
TYPES tt_cat TYPE RANGE OF {{p}}vehicle-category.
METHODS run
IMPORTING iv_from TYPE d
iv_to TYPE d
it_cat TYPE tt_cat OPTIONAL
RETURNING VALUE(rr_data) TYPE REF TO data.
METHODS lines_of
IMPORTING ir_data TYPE REF TO data
RETURNING VALUE(rv_lines) TYPE i.
METHODS value_of
IMPORTING ir_data TYPE REF TO data
iv_row TYPE i
iv_col TYPE string
RETURNING VALUE(rv_value) TYPE string.
METHODS all_vehicles FOR TESTING.
METHODS sorted_by_total FOR TESTING.
METHODS date_range_inclusive FOR TESTING.
METHODS category_filter FOR TESTING.
METHODS fuel_and_toll FOR TESTING.
METHODS cost_per_km FOR TESTING.
METHODS vehicles_without_trips FOR TESTING.
ENDCLASS.
CLASS {{p}}fleet_hidden IMPLEMENTATION.
METHOD run.
cl_salv_bs_runtime_info=>set( display = abap_false metadata = abap_false data = abap_true ).
SUBMIT {{p}}fleet_cost_old
WITH p_from = iv_from
WITH p_to = iv_to
WITH s_cat IN it_cat
AND RETURN.
TRY.
cl_salv_bs_runtime_info=>get_data_ref( IMPORTING r_data = rr_data ).
CATCH cx_salv_bs_sc_runtime_info.
ENDTRY.
cl_salv_bs_runtime_info=>clear_all( ).
ENDMETHOD.
METHOD lines_of.
FIELD-SYMBOLS <lt_data> TYPE STANDARD TABLE.
IF ir_data IS BOUND.
ASSIGN ir_data->* TO <lt_data>.
rv_lines = lines( <lt_data> ).
ENDIF.
ENDMETHOD.
METHOD value_of.
FIELD-SYMBOLS <lt_data> TYPE STANDARD TABLE.
ASSIGN ir_data->* TO <lt_data>.
ASSIGN <lt_data>[ iv_row ] TO FIELD-SYMBOL(<ls_line>).
ASSIGN COMPONENT iv_col OF STRUCTURE <ls_line> TO FIELD-SYMBOL(<lv_value>).
cl_abap_unit_assert=>assert_subrc( exp = 0 msg = |Column { iv_col } is missing| ).
rv_value = condense( CONV string( <lv_value> ) ).
ENDMETHOD.
METHOD all_vehicles.
cl_abap_unit_assert=>assert_equals(
exp = 3
act = lines_of( run( iv_from = '20260101' iv_to = '20260131' ) ) ).
ENDMETHOD.
METHOD sorted_by_total.
DATA(lr_data) = run( iv_from = '20260101' iv_to = '20260131' ).
cl_abap_unit_assert=>assert_equals( exp = `V02` act = value_of( ir_data = lr_data iv_row = 1 iv_col = `VEHICLE_ID` ) ).
cl_abap_unit_assert=>assert_equals( exp = `V01` act = value_of( ir_data = lr_data iv_row = 2 iv_col = `VEHICLE_ID` ) ).
cl_abap_unit_assert=>assert_equals( exp = `V03` act = value_of( ir_data = lr_data iv_row = 3 iv_col = `VEHICLE_ID` ) ).
ENDMETHOD.
METHOD date_range_inclusive.
DATA(lr_first) = run( iv_from = '20260101' iv_to = '20260101' ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lines_of( lr_first ) ).
cl_abap_unit_assert=>assert_equals( exp = `V03` act = value_of( ir_data = lr_first iv_row = 1 iv_col = `VEHICLE_ID` ) ).
cl_abap_unit_assert=>assert_equals( exp = `20.0` act = value_of( ir_data = lr_first iv_row = 1 iv_col = `DISTANCE` ) ).
DATA(lr_last) = run( iv_from = '20260131' iv_to = '20260131' ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lines_of( lr_last ) ).
cl_abap_unit_assert=>assert_equals( exp = `V03` act = value_of( ir_data = lr_last iv_row = 1 iv_col = `VEHICLE_ID` ) ).
cl_abap_unit_assert=>assert_equals( exp = `10.0` act = value_of( ir_data = lr_last iv_row = 1 iv_col = `DISTANCE` ) ).
ENDMETHOD.
METHOD category_filter.
DATA(lr_data) = run( iv_from = '20260101' iv_to = '20260131'
it_cat = VALUE #( ( sign = 'I' option = 'EQ' low = 'TRUCK' ) ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lines_of( lr_data ) ).
cl_abap_unit_assert=>assert_equals( exp = `V02` act = value_of( ir_data = lr_data iv_row = 1 iv_col = `VEHICLE_ID` ) ).
cl_abap_unit_assert=>assert_equals( exp = `47.00` act = value_of( ir_data = lr_data iv_row = 1 iv_col = `TOTAL_COST` ) ).
ENDMETHOD.
METHOD fuel_and_toll.
DATA(lr_data) = run( iv_from = '20260101' iv_to = '20260131' ).
cl_abap_unit_assert=>assert_equals( exp = `200.0` act = value_of( ir_data = lr_data iv_row = 1 iv_col = `DISTANCE` ) ).
cl_abap_unit_assert=>assert_equals( exp = `42.00` act = value_of( ir_data = lr_data iv_row = 1 iv_col = `FUEL_COST` ) ).
cl_abap_unit_assert=>assert_equals( exp = `5.00` act = value_of( ir_data = lr_data iv_row = 1 iv_col = `TOLL_COST` ) ).
cl_abap_unit_assert=>assert_equals( exp = `47.00` act = value_of( ir_data = lr_data iv_row = 1 iv_col = `TOTAL_COST` ) ).
ENDMETHOD.
METHOD cost_per_km.
DATA(lr_data) = run( iv_from = '20260101' iv_to = '20260131' ).
cl_abap_unit_assert=>assert_equals( exp = `0.235` act = value_of( ir_data = lr_data iv_row = 1 iv_col = `COST_PER_KM` ) ).
cl_abap_unit_assert=>assert_equals( exp = `0.163` act = value_of( ir_data = lr_data iv_row = 2 iv_col = `COST_PER_KM` ) ).
cl_abap_unit_assert=>assert_equals( exp = `0.164` act = value_of( ir_data = lr_data iv_row = 3 iv_col = `COST_PER_KM` ) ).
ENDMETHOD.
METHOD vehicles_without_trips.
DATA(lr_data) = run( iv_from = '20260101' iv_to = '20260131' ).
DO lines_of( lr_data ) TIMES.
cl_abap_unit_assert=>assert_differs(
exp = `V04`
act = value_of( ir_data = lr_data iv_row = sy-index iv_col = `VEHICLE_ID` ) ).
ENDDO.
ENDMETHOD.
ENDCLASS.

View File

@@ -0,0 +1,55 @@
{
"task": "G0190",
"mutants": [
{
"object": "{{P}}FLEET_COST_OLD",
"mutant": "line 43: * -> / (arith)",
"status": "invalid",
"hidden": "0/0",
"failed_tests": []
},
{
"object": "{{P}}FLEET_COST_OLD",
"mutant": "line 48: AND -> OR (logic)",
"status": "killed",
"hidden": "3/7",
"failed_tests": [
"CATEGORY_FILTER",
"COST_PER_KM",
"DATE_RANGE_INCLUSIVE",
"FUEL_AND_TOLL"
]
},
{
"object": "{{P}}FLEET_COST_OLD",
"mutant": "line 60: + -> - (arith)",
"status": "killed",
"hidden": "4/7",
"failed_tests": [
"CATEGORY_FILTER",
"COST_PER_KM",
"FUEL_AND_TOLL"
]
},
{
"object": "{{P}}FLEET_COST_OLD",
"mutant": "line 69: > -> <= (rel)",
"status": "killed",
"hidden": "6/7",
"failed_tests": [
"COST_PER_KM"
]
},
{
"object": "{{P}}FLEET_COST_OLD",
"mutant": "line 70: 3 -> 4 (const)",
"status": "survived",
"hidden": "7/7",
"failed_tests": []
}
],
"valid": 4,
"killed": 3,
"kill_rate": 0.75,
"ok": true
}

View File

@@ -0,0 +1,149 @@
REPORT {{p}}fleet_cost_old.
PARAMETERS p_from TYPE d OBLIGATORY.
PARAMETERS p_to TYPE d OBLIGATORY.
DATA gv_cat TYPE {{p}}vehicle-category.
SELECT-OPTIONS s_cat FOR gv_cat.
CLASS lcl_fleet DEFINITION FINAL.
PUBLIC SECTION.
TYPES:
BEGIN OF ty_line,
vehicle_id TYPE {{p}}vehicle-vehicle_id,
plate TYPE {{p}}vehicle-plate,
category TYPE {{p}}vehicle-category,
distance TYPE {{p}}trip-distance_km,
fuel_cost TYPE {{p}}trip-toll_fee,
toll_cost TYPE {{p}}trip-toll_fee,
total_cost TYPE {{p}}trip-toll_fee,
cost_per_km TYPE p LENGTH 15 DECIMALS 3,
END OF ty_line,
tt_line TYPE STANDARD TABLE OF ty_line WITH EMPTY KEY,
tt_cat TYPE RANGE OF {{p}}vehicle-category.
CLASS-METHODS select_costs
IMPORTING iv_from TYPE d
iv_to TYPE d
it_cat TYPE tt_cat
RETURNING VALUE(rt_lines) TYPE tt_line.
CLASS-METHODS show
CHANGING ct_lines TYPE tt_line.
PRIVATE SECTION.
CLASS-METHODS cost_per_km
IMPORTING is_line TYPE ty_line
RETURNING VALUE(rv_value) TYPE ty_line-cost_per_km.
ENDCLASS.
CLASS lcl_fleet IMPLEMENTATION.
METHOD select_costs.
SELECT v~vehicle_id,
v~plate,
v~category,
SUM( t~distance_km ) AS distance,
SUM( t~fuel_liters * t~fuel_price ) AS fuel_cost,
SUM( t~toll_fee ) AS toll_cost
FROM {{p}}vehicle AS v
INNER JOIN {{p}}trip AS t ON t~vehicle_id = v~vehicle_id
WHERE t~trip_date BETWEEN @iv_from AND @iv_to
AND v~category IN @it_cat
GROUP BY v~vehicle_id, v~plate, v~category
INTO TABLE @DATA(lt_sums).
LOOP AT lt_sums INTO DATA(ls_sum).
DATA(ls_line) = VALUE ty_line(
vehicle_id = ls_sum-vehicle_id
plate = ls_sum-plate
category = ls_sum-category
distance = ls_sum-distance
fuel_cost = ls_sum-fuel_cost
toll_cost = ls_sum-toll_cost
total_cost = ls_sum-fuel_cost + ls_sum-toll_cost ).
ls_line-cost_per_km = cost_per_km( ls_line ).
APPEND ls_line TO rt_lines.
ENDLOOP.
SORT rt_lines BY total_cost DESCENDING.
ENDMETHOD.
METHOD cost_per_km.
IF is_line-distance > 0.
rv_value = ROUND( val = is_line-total_cost / is_line-distance dec = 3 ).
ENDIF.
ENDMETHOD.
METHOD show.
TRY.
cl_salv_table=>factory( IMPORTING r_salv_table = DATA(lo_alv)
CHANGING t_table = ct_lines ).
lo_alv->display( ).
CATCH cx_salv_msg INTO DATA(lx_error).
MESSAGE lx_error TYPE 'I' DISPLAY LIKE 'E'.
ENDTRY.
ENDMETHOD.
ENDCLASS.
START-OF-SELECTION.
DATA(gt_lines) = lcl_fleet=>select_costs( iv_from = p_from
iv_to = p_to
it_cat = s_cat[] ).
lcl_fleet=>show( CHANGING ct_lines = gt_lines ).
CLASS ltc_fleet DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
PRIVATE SECTION.
CLASS-DATA go_env TYPE REF TO if_osql_test_environment.
CLASS-METHODS class_setup.
CLASS-METHODS class_teardown.
METHODS totals_per_vehicle FOR TESTING.
METHODS period_filter FOR TESTING.
METHODS category_filter FOR TESTING.
ENDCLASS.
CLASS ltc_fleet IMPLEMENTATION.
METHOD class_setup.
go_env = cl_osql_test_environment=>create(
i_dependency_list = VALUE #( ( '{{P}}VEHICLE' ) ( '{{P}}TRIP' ) ) ).
DATA lt_vehicle TYPE STANDARD TABLE OF {{p}}vehicle WITH EMPTY KEY.
lt_vehicle = VALUE #( ( vehicle_id = 'V1' plate = 'AAA' category = 'VAN' )
( vehicle_id = 'V2' plate = 'BBB' category = 'TRUCK' ) ).
go_env->insert_test_data( lt_vehicle ).
DATA lt_trip TYPE STANDARD TABLE OF {{p}}trip WITH EMPTY KEY.
lt_trip = VALUE #( ( trip_id = 1 vehicle_id = 'V1' trip_date = '20260105'
distance_km = 100 fuel_liters = 10 fuel_price = 2 toll_fee = 1 )
( trip_id = 2 vehicle_id = 'V2' trip_date = '20260106'
distance_km = 50 fuel_liters = 5 fuel_price = 2 toll_fee = 0 ) ).
go_env->insert_test_data( lt_trip ).
ENDMETHOD.
METHOD class_teardown.
go_env->destroy( ).
ENDMETHOD.
METHOD totals_per_vehicle.
DATA(lt_lines) = lcl_fleet=>select_costs( iv_from = '20260101'
iv_to = '20260131'
it_cat = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = 2 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'V1' act = lt_lines[ 1 ]-vehicle_id ).
cl_abap_unit_assert=>assert_equals( exp = CONV {{p}}trip-toll_fee( 21 ) act = lt_lines[ 1 ]-total_cost ).
cl_abap_unit_assert=>assert_equals( exp = 'V2' act = lt_lines[ 2 ]-vehicle_id ).
ENDMETHOD.
METHOD period_filter.
DATA(lt_lines) = lcl_fleet=>select_costs( iv_from = '20260106'
iv_to = '20260106'
it_cat = VALUE #( ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'V2' act = lt_lines[ 1 ]-vehicle_id ).
ENDMETHOD.
METHOD category_filter.
DATA(lt_lines) = lcl_fleet=>select_costs(
iv_from = '20260101'
iv_to = '20260131'
it_cat = VALUE #( ( sign = 'I' option = 'EQ' low = 'TRUCK' ) ) ).
cl_abap_unit_assert=>assert_equals( exp = 1 act = lines( lt_lines ) ).
cl_abap_unit_assert=>assert_equals( exp = 'V2' act = lt_lines[ 1 ]-vehicle_id ).
ENDMETHOD.
ENDCLASS.

View File

@@ -0,0 +1,75 @@
REPORT {{p}}fleet_cost_old.
TYPES: BEGIN OF ty_out,
vehicle_id TYPE {{p}}vehicle-vehicle_id,
plate TYPE {{p}}vehicle-plate,
category TYPE {{p}}vehicle-category,
distance TYPE {{p}}trip-distance_km,
fuel_cost TYPE {{p}}trip-toll_fee,
toll_cost TYPE {{p}}trip-toll_fee,
total_cost TYPE {{p}}trip-toll_fee,
cost_per_km TYPE p LENGTH 15 DECIMALS 3,
END OF ty_out.
DATA: gt_out TYPE STANDARD TABLE OF ty_out,
gt_vehicle TYPE STANDARD TABLE OF {{p}}vehicle,
gt_trip TYPE STANDARD TABLE OF {{p}}trip,
gs_vehicle TYPE {{p}}vehicle,
gs_trip TYPE {{p}}trip,
gs_out TYPE ty_out,
go_alv TYPE REF TO cl_salv_table,
gv_cat TYPE {{p}}vehicle-category.
PARAMETERS: p_from TYPE d OBLIGATORY,
p_to TYPE d OBLIGATORY.
SELECT-OPTIONS: s_cat FOR gv_cat.
START-OF-SELECTION.
SELECT * FROM {{p}}vehicle INTO TABLE gt_vehicle.
LOOP AT gt_vehicle INTO gs_vehicle.
IF gs_vehicle-category IN s_cat.
CLEAR gs_out.
gs_out-vehicle_id = gs_vehicle-vehicle_id.
gs_out-plate = gs_vehicle-plate.
gs_out-category = gs_vehicle-category.
SELECT * FROM {{p}}trip INTO TABLE gt_trip
WHERE vehicle_id = gs_vehicle-vehicle_id
AND trip_date >= p_from
AND trip_date <= p_to.
IF sy-subrc = 0.
LOOP AT gt_trip INTO gs_trip.
gs_out-distance = gs_out-distance + gs_trip-distance_km.
gs_out-fuel_cost = gs_out-fuel_cost + gs_trip-fuel_liters * gs_trip-fuel_price.
gs_out-toll_cost = gs_out-toll_cost + gs_trip-toll_fee.
ENDLOOP.
gs_out-total_cost = gs_out-fuel_cost + gs_out-toll_cost.
IF gs_out-distance > 0.
gs_out-cost_per_km = gs_out-total_cost / gs_out-distance.
ENDIF.
APPEND gs_out TO gt_out.
ENDIF.
ENDIF.
ENDLOOP.
SORT gt_out BY total_cost DESCENDING.
TRY.
cl_salv_table=>factory( IMPORTING r_salv_table = go_alv
CHANGING t_table = gt_out ).
go_alv->display( ).
CATCH cx_salv_msg.
ENDTRY.

View File

@@ -0,0 +1,29 @@
CLASS {{p}}fleet_seed DEFINITION PUBLIC FINAL CREATE PUBLIC.
PUBLIC SECTION.
INTERFACES if_oo_adt_classrun.
ENDCLASS.
CLASS {{p}}fleet_seed IMPLEMENTATION.
METHOD if_oo_adt_classrun~main.
DELETE FROM {{p}}trip.
DELETE FROM {{p}}vehicle.
INSERT {{p}}vehicle FROM TABLE @( VALUE #(
( vehicle_id = 'V01' plate = 'B-AA 100' category = 'VAN' )
( vehicle_id = 'V02' plate = 'B-BB 200' category = 'TRUCK' )
( vehicle_id = 'V03' plate = 'B-CC 300' category = 'VAN' )
( vehicle_id = 'V04' plate = 'B-DD 400' category = 'TRUCK' ) ) ).
INSERT {{p}}trip FROM TABLE @( VALUE #(
( trip_id = 1 vehicle_id = 'V01' trip_date = '20260105' distance_km = '100.0' fuel_liters = '10.00' fuel_price = '1.50' toll_fee = '2.00' )
( trip_id = 2 vehicle_id = 'V01' trip_date = '20260110' distance_km = '50.0' fuel_liters = '5.00' fuel_price = '1.50' toll_fee = '0.00' )
( trip_id = 3 vehicle_id = 'V02' trip_date = '20260107' distance_km = '200.0' fuel_liters = '30.00' fuel_price = '1.40' toll_fee = '5.00' )
( trip_id = 4 vehicle_id = 'V03' trip_date = '20260101' distance_km = '20.0' fuel_liters = '2.00' fuel_price = '1.50' toll_fee = '0.00' )
( trip_id = 5 vehicle_id = 'V03' trip_date = '20260120' distance_km = '80.0' fuel_liters = '8.00' fuel_price = '1.50' toll_fee = '1.50' )
( trip_id = 6 vehicle_id = 'V03' trip_date = '20260131' distance_km = '10.0' fuel_liters = '1.00' fuel_price = '1.50' toll_fee = '0.00' )
( trip_id = 7 vehicle_id = 'V01' trip_date = '20251231' distance_km = '500.0' fuel_liters = '50.00' fuel_price = '1.50' toll_fee = '9.99' )
( trip_id = 8 vehicle_id = 'V02' trip_date = '20260205' distance_km = '300.0' fuel_liters = '40.00' fuel_price = '1.40' toll_fee = '7.77' ) ) ).
out->write( sy-dbcnt ).
ENDMETHOD.
ENDCLASS.

View File

@@ -0,0 +1,15 @@
@EndUserText.label : 'Trip'
@AbapCatalog.enhancement.category : #NOT_EXTENSIBLE
@AbapCatalog.tableCategory : #TRANSPARENT
@AbapCatalog.deliveryClass : #A
@AbapCatalog.dataMaintenance : #RESTRICTED
define table {{p}}trip {
key client : abap.clnt not null;
key trip_id : abap.int4 not null;
vehicle_id : abap.char(10);
trip_date : abap.dats;
distance_km : abap.dec(13,1);
fuel_liters : abap.dec(13,2);
fuel_price : abap.dec(13,2);
toll_fee : abap.dec(13,2);
}

View File

@@ -0,0 +1,11 @@
@EndUserText.label : 'Vehicle master'
@AbapCatalog.enhancement.category : #NOT_EXTENSIBLE
@AbapCatalog.tableCategory : #TRANSPARENT
@AbapCatalog.deliveryClass : #A
@AbapCatalog.dataMaintenance : #RESTRICTED
define table {{p}}vehicle {
key client : abap.clnt not null;
key vehicle_id : abap.char(10) not null;
plate : abap.char(10);
category : abap.char(4);
}

View File

@@ -0,0 +1,47 @@
# 1. Goal
Refactor the legacy report {{P}}FLEET_COST_OLD in package $TMP. The report
shows the running cost of each vehicle of a company fleet for a period. The
behavior of the report stays the same. Improve the internal quality of the
source code.
# 2. Open questions
None.
# 3. Context
- The program {{P}}FLEET_COST_OLD exists in package $TMP. It is active and it
produces a correct result. Its source code is of poor quality.
- The tables {{P}}VEHICLE and {{P}}TRIP exist in package $TMP. They contain
data. The report reads these two tables.
- The report shows the result in an ALV list.
- The users report no functional defect. Do not change the behavior.
- The report is not in the out-of-scope list. Refactor it in place.
# 4. Contract
- The program keeps the name {{P}}FLEET_COST_OLD and the package $TMP.
- The selection screen keeps these fields, in this order:
- Parameter P_FROM, type DATS, mandatory.
- Parameter P_TO, type DATS, mandatory.
- Select-option S_CAT for the vehicle category.
- The ALV list keeps the same columns with the same names: VEHICLE_ID, PLATE,
CATEGORY, DISTANCE, FUEL_COST, TOLL_COST, TOTAL_COST, COST_PER_KM.
- The lines of the list and the order of the lines do not change.
# 5. Business rules
The behavior stays the same. The legacy source code of {{P}}FLEET_COST_OLD
contains all the rules. Read the legacy code. Keep every rule. Do not add a
rule and do not remove a rule.
# 6. Constraints
- Release target: 8.16.
- Coding standards: Clean ABAP.
- Do not read a database table inside a loop.
- A method has less than 40 statements.
- The maximum nesting depth is 3.
- Use meaningful names.
- Out of scope: do not change the tables {{P}}VEHICLE and {{P}}TRIP. Do not
change the selection screen fields. Do not change the ALV column names.
# 7. Acceptance
- The program {{P}}FLEET_COST_OLD is active and has no syntax error.
- The hidden tests pass.
- Write ABAP Unit tests as local test classes in the program.

View File

@@ -0,0 +1,74 @@
{
"id": "G0190",
"category": "E",
"object_type": "PROG",
"difficulty": 2,
"release_target": "v816",
"expected_outcome": "implement",
"budget": {
"max_tool_calls": 40,
"max_activations": 10
},
"seed": [
{
"type": "TABL",
"name": "{{P}}VEHICLE",
"file": "seed/vehicle.tabl.asabap",
"description": "Vehicle master of the company fleet"
},
{
"type": "TABL",
"name": "{{P}}TRIP",
"file": "seed/trip.tabl.asabap",
"description": "Trips of the vehicles"
},
{
"type": "PROG",
"name": "{{P}}FLEET_COST_OLD",
"file": "seed/fleet_cost_old.prog.abap",
"description": "Legacy fleet cost report"
},
{
"type": "CLAS",
"name": "{{P}}FLEET_SEED",
"file": "seed/fleet_seed.clas.abap",
"description": "Fleet seed data",
"run": true
}
],
"contract": [
{
"type": "PROG",
"name": "{{P}}FLEET_COST_OLD",
"parameters": [
"p_from",
"p_to",
"s_cat"
]
}
],
"out_of_scope": [
"{{P}}VEHICLE",
"{{P}}TRIP"
],
"hidden_tests": [
{
"type": "CLAS",
"name": "{{P}}FLEET_HIDDEN",
"file": "hidden/fleet_hidden.clas.abap",
"description": "Hidden tests for the fleet cost report"
}
],
"reference": [
{
"type": "PROG",
"name": "{{P}}FLEET_COST_OLD",
"file": "reference/fleet_cost_old.prog.abap",
"description": "Refactored fleet cost report"
}
],
"craft_checks": [
"db_operation_in_loop",
"method_length"
]
}