erhan/abap-llm
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Generator: pilot analysis and fixes; G0002-G0021 tasks; handover notes merged

Browse Source 
- Static bundle checks (name length, seed type, reserved words, contract test classes,
  testclasses_file), local abaplint parser check before SAP, max_tokens, robust JSON parse
- Runner: G2 for CDS views with parameters, contract_check detail in report
- G0020 and G0013 fixed by review and revalidated (oracle 100, null 0)
- Pilot results in docs/faz1-tasarim.md 11e; handover notes merged into CLAUDE.md and docs

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Kral
2026-10-03 05:04:23 +02:00
parent 15eb9f1bb2
commit 5de5e2851c
162 changed files with 9943 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tasks_gen/eval/G0005/reference/cx_freight_error.clas.abap Normal file
View File

@@ -0,0 +1,11 @@
CLASS {{p}}cx_freight_error DEFINITION PUBLIC INHERITING FROM cx_static_check ABSTRACT.
PUBLIC SECTION.
DATA mv_zone_code TYPE c LENGTH 4.
METHODS get_reason_text ABSTRACT
RETURNING VALUE(rv_text) TYPE string.
ENDCLASS.
CLASS {{p}}cx_freight_error IMPLEMENTATION.
ENDCLASS.

13
tasks_gen/eval/G0005/reference/cx_invalid_weight.clas.abap Normal file
View File

@@ -0,0 +1,13 @@
CLASS {{p}}cx_invalid_weight DEFINITION PUBLIC INHERITING FROM {{p}}cx_freight_error FINAL CREATE PUBLIC.
PUBLIC SECTION.
DATA mv_weight_kg TYPE p LENGTH 15 DECIMALS 3.
METHODS get_reason_text REDEFINITION.
ENDCLASS.
CLASS {{p}}cx_invalid_weight IMPLEMENTATION.
METHOD get_reason_text.
rv_text = 'Weight must be greater than zero'.
ENDMETHOD.
ENDCLASS.

11
tasks_gen/eval/G0005/reference/cx_unknown_zone.clas.abap Normal file
View File

@@ -0,0 +1,11 @@
CLASS {{p}}cx_unknown_zone DEFINITION PUBLIC INHERITING FROM {{p}}cx_freight_error FINAL CREATE PUBLIC.
PUBLIC SECTION.
METHODS get_reason_text REDEFINITION.
ENDCLASS.
CLASS {{p}}cx_unknown_zone IMPLEMENTATION.
METHOD get_reason_text.
rv_text = |Zone { condense( mv_zone_code ) } is not known|.
ENDMETHOD.
ENDCLASS.

14
tasks_gen/eval/G0005/reference/cx_weight_limit.clas.abap Normal file
View File

@@ -0,0 +1,14 @@
CLASS {{p}}cx_weight_limit DEFINITION PUBLIC INHERITING FROM {{p}}cx_freight_error FINAL CREATE PUBLIC.
PUBLIC SECTION.
DATA mv_weight_kg TYPE p LENGTH 15 DECIMALS 3.
DATA mv_max_weight_kg TYPE i.
METHODS get_reason_text REDEFINITION.
ENDCLASS.
CLASS {{p}}cx_weight_limit IMPLEMENTATION.
METHOD get_reason_text.
rv_text = 'Weight exceeds the zone limit'.
ENDMETHOD.
ENDCLASS.

73
tasks_gen/eval/G0005/reference/freight_calc.clas.abap Normal file
View File

@@ -0,0 +1,73 @@
CLASS {{p}}freight_calc DEFINITION PUBLIC FINAL CREATE PUBLIC.
PUBLIC SECTION.
TYPES ty_cost TYPE p LENGTH 15 DECIMALS 2.
TYPES ty_weight TYPE p LENGTH 15 DECIMALS 3.
TYPES: BEGIN OF ty_result,
cost TYPE ty_cost,
currency TYPE c LENGTH 5,
END OF ty_result.
METHODS calculate
IMPORTING iv_zone_code TYPE c LENGTH 4
iv_weight_kg TYPE ty_weight
iv_express TYPE abap_bool DEFAULT abap_false
RETURNING VALUE(rs_result) TYPE ty_result
RAISING {{p}}cx_freight_error.
PRIVATE SECTION.
CONSTANTS c_express_factor TYPE p LENGTH 5 DECIMALS 2 VALUE '1.50'.
CONSTANTS c_minimum_charge TYPE ty_cost VALUE '6.00'.
METHODS find_zone
IMPORTING iv_zone_code TYPE c LENGTH 4
RETURNING VALUE(rs_zone) TYPE {{p}}zone_master=>ty_zone
RAISING {{p}}cx_freight_error.
ENDCLASS.
CLASS {{p}}freight_calc IMPLEMENTATION.
METHOD calculate.
DATA lv_zone_code TYPE c LENGTH 4.
lv_zone_code = to_upper( iv_zone_code ).
IF iv_weight_kg <= 0.
DATA(lo_invalid) = NEW {{p}}cx_invalid_weight( ).
lo_invalid->mv_zone_code = lv_zone_code.
lo_invalid->mv_weight_kg = iv_weight_kg.
RAISE EXCEPTION lo_invalid.
ENDIF.
DATA(ls_zone) = find_zone( lv_zone_code ).
IF iv_weight_kg > ls_zone-max_weight_kg.
DATA(lo_limit) = NEW {{p}}cx_weight_limit( ).
lo_limit->mv_zone_code = lv_zone_code.
lo_limit->mv_weight_kg = iv_weight_kg.
lo_limit->mv_max_weight_kg = ls_zone-max_weight_kg.
RAISE EXCEPTION lo_limit.
ENDIF.
DATA lv_cost TYPE p LENGTH 15 DECIMALS 5.
lv_cost = ls_zone-base_fee + iv_weight_kg * ls_zone-price_per_kg.
IF iv_express = abap_true.
lv_cost = lv_cost * c_express_factor.
ENDIF.
lv_cost = round( val = lv_cost dec = 2 ).
IF lv_cost < c_minimum_charge.
lv_cost = c_minimum_charge.
ENDIF.
rs_result-cost = lv_cost.
rs_result-currency = ls_zone-currency.
ENDMETHOD.
METHOD find_zone.
DATA(lt_zone) = {{p}}zone_master=>get_all( ).
READ TABLE lt_zone INTO rs_zone WITH KEY zone_code = iv_zone_code.
IF sy-subrc <> 0.
DATA(lo_unknown) = NEW {{p}}cx_unknown_zone( ).
lo_unknown->mv_zone_code = iv_zone_code.
RAISE EXCEPTION lo_unknown.
ENDIF.
ENDMETHOD.
ENDCLASS.

98
tasks_gen/eval/G0005/reference/freight_calc.testclasses.abap Normal file
View File

@@ -0,0 +1,98 @@
CLASS ltc_freight_calc DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
PRIVATE SECTION.
TYPES ty_cost TYPE p LENGTH 15 DECIMALS 2.
TYPES ty_currency TYPE c LENGTH 5.
TYPES ty_zone_code TYPE c LENGTH 4.
TYPES ty_weight TYPE p LENGTH 15 DECIMALS 3.
DATA mo_cut TYPE REF TO {{p}}freight_calc.
METHODS setup.
METHODS assert_cost
IMPORTING iv_cost TYPE ty_cost
iv_currency TYPE ty_currency
is_result TYPE {{p}}freight_calc=>ty_result.
METHODS calculate_result
IMPORTING iv_zone_code TYPE ty_zone_code
iv_weight_kg TYPE ty_weight
iv_express TYPE abap_bool DEFAULT abap_false
RETURNING VALUE(rs_result) TYPE {{p}}freight_calc=>ty_result.
METHODS standard_cost FOR TESTING.
METHODS express_cost FOR TESTING.
METHODS minimum_charge FOR TESTING.
METHODS unknown_zone FOR TESTING.
METHODS invalid_weight FOR TESTING.
METHODS weight_limit FOR TESTING.
ENDCLASS.
CLASS ltc_freight_calc IMPLEMENTATION.
METHOD setup.
mo_cut = NEW {{p}}freight_calc( ).
ENDMETHOD.
METHOD assert_cost.
cl_abap_unit_assert=>assert_equals( exp = iv_cost act = is_result-cost ).
cl_abap_unit_assert=>assert_equals( exp = iv_currency act = is_result-currency ).
ENDMETHOD.
METHOD calculate_result.
TRY.
rs_result = mo_cut->calculate( iv_zone_code = iv_zone_code
iv_weight_kg = iv_weight_kg
iv_express = iv_express ).
CATCH {{p}}cx_freight_error INTO DATA(lo_error).
cl_abap_unit_assert=>fail( msg = lo_error->get_reason_text( ) ).
ENDTRY.
ENDMETHOD.
METHOD standard_cost.
DATA(ls_result) = calculate_result( iv_zone_code = 'DE01' iv_weight_kg = '10.000' ).
assert_cost( iv_cost = '17.00' iv_currency = 'EUR' is_result = ls_result ).
ENDMETHOD.
METHOD express_cost.
DATA(ls_result) = calculate_result( iv_zone_code = 'DE01'
iv_weight_kg = '10.000'
iv_express = abap_true ).
assert_cost( iv_cost = '25.50' iv_currency = 'EUR' is_result = ls_result ).
ENDMETHOD.
METHOD minimum_charge.
DATA(ls_result) = calculate_result( iv_zone_code = 'DE01' iv_weight_kg = '0.500' ).
assert_cost( iv_cost = '6.00' iv_currency = 'EUR' is_result = ls_result ).
ENDMETHOD.
METHOD unknown_zone.
TRY.
mo_cut->calculate( iv_zone_code = 'XX99' iv_weight_kg = '1.000' ).
cl_abap_unit_assert=>fail( msg = 'CX_UNKNOWN_ZONE expected' ).
CATCH {{p}}cx_unknown_zone INTO DATA(lo_unknown).
cl_abap_unit_assert=>assert_equals( exp = 'XX99' act = lo_unknown->mv_zone_code ).
CATCH {{p}}cx_freight_error INTO DATA(lo_other).
cl_abap_unit_assert=>fail( msg = |Wrong exception class: { lo_other->get_reason_text( ) }| ).
ENDTRY.
ENDMETHOD.
METHOD invalid_weight.
TRY.
mo_cut->calculate( iv_zone_code = 'DE01' iv_weight_kg = '0.000' ).
cl_abap_unit_assert=>fail( msg = 'CX_INVALID_WEIGHT expected' ).
CATCH {{p}}cx_invalid_weight INTO DATA(lo_invalid).
cl_abap_unit_assert=>assert_equals( exp = 'DE01' act = lo_invalid->mv_zone_code ).
CATCH {{p}}cx_freight_error INTO DATA(lo_other).
cl_abap_unit_assert=>fail( msg = |Wrong exception class: { lo_other->get_reason_text( ) }| ).
ENDTRY.
ENDMETHOD.
METHOD weight_limit.
TRY.
mo_cut->calculate( iv_zone_code = 'CN01' iv_weight_kg = '20.001' ).
cl_abap_unit_assert=>fail( msg = 'CX_WEIGHT_LIMIT expected' ).
CATCH {{p}}cx_weight_limit INTO DATA(lo_limit).
cl_abap_unit_assert=>assert_equals( exp = 'CN01' act = lo_limit->mv_zone_code ).
CATCH {{p}}cx_freight_error INTO DATA(lo_other).
cl_abap_unit_assert=>fail( msg = |Wrong exception class: { lo_other->get_reason_text( ) }| ).
ENDTRY.
ENDMETHOD.
ENDCLASS.